This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Resolve Code Review Comments #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotrick
reviewed
Jan 12, 2018
|
|
||
| * Check the box to agree to the Terms of Service. | ||
|
|
||
| * Click “Done” on the Configure MS Teams page in the bottom left hand corner. | ||
|
|
||
| * Bots and Microsoft Azure – When you edit the properties of an existing bot in the list of your bots in Bot Framework such as its messaging endpoint, which is common when first developing a bot, especially if you use ngrok, you will see the "Migration status" column and a blue "Migrate" button that will take you into the Microsoft Azure portal. Don't click on the "Migrate" button unless that's what you want to do; instead, click on the name of the bot and you can edit its properties. | ||
|
|
||
| * If you register your bot using Microsoft Azure, it does not need to be hosted on Microsoft Azure. | ||
| * If you do register a bot using the Microsoft Azure portal, it does not need to be hosted on Microsoft Azure. |
There was a problem hiding this comment.
I like that you added the "the" and "portal", but change the "do" and "a" back to "your bot" so that this bullet and the next do not start with the exact same phrase.
jotrick
reviewed
Jan 12, 2018
|
|
||
| * If you do register a bot using Microsoft Azure portal, you must have a Microsoft Azure account. You can create one for free. To verify your identity when you create one, you must provide a credit card, but it won't be charged; it's always free to create and use bots with Microsoft Teams. | ||
| * If you do register a bot using the Microsoft Azure portal, you must have a Microsoft Azure account. You can create one for free. To verify your identity when you create one, you must provide a credit card, but it won't be charged; it's always free to create and use bots with Microsoft Teams. |
There was a problem hiding this comment.
Change so that the formatting is correct with this when viewed in the actual view. (so that it doesn't show up with the *)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jotrick @msftdherron @aosolis @MattSFT @goelashish7 @jialic