Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Resolve Code Review Comments #10

Open
wants to merge 1 commit into
base: vamagra-patch-1
Choose a base branch
from
Open

Resolve Code Review Comments #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,17 +82,17 @@ In addition, every bot must be registered in the Bot Framework, so it is accessi

* You’ll return to the Registration page, with the App ID filled in, that matches the one created above. Check the box at the bottom to agree to the terms of use, and click “Register” to create your new accessible Bot Framework bot.

* Click on the Microsoft Teams icon under “Add a featured channel.”
* On the new page that opens once your app is done being created, click on the Microsoft Teams icon under "Add a featured channel" in order to allow your bot to use this channel.

* Check the box to agree to the Terms of Service.

* Click “Done” on the Configure MS Teams page in the bottom left hand corner.

* Bots and Microsoft Azure – When you edit the properties of an existing bot in the list of your bots in Bot Framework such as its messaging endpoint, which is common when first developing a bot, especially if you use ngrok, you will see the "Migration status" column and a blue "Migrate" button that will take you into the Microsoft Azure portal. Don't click on the "Migrate" button unless that's what you want to do; instead, click on the name of the bot and you can edit its properties.

* If you register your bot using Microsoft Azure, it does not need to be hosted on Microsoft Azure.
* If you do register a bot using the Microsoft Azure portal, it does not need to be hosted on Microsoft Azure.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you added the "the" and "portal", but change the "do" and "a" back to "your bot" so that this bullet and the next do not start with the exact same phrase.


   * If you do register a bot using Microsoft Azure portal, you must have a Microsoft Azure account. You can create one for free. To verify your identity when you create one, you must provide a credit card, but it won't be charged; it's always free to create and use bots with Microsoft Teams.
   * If you do register a bot using the Microsoft Azure portal, you must have a Microsoft Azure account. You can create one for free. To verify your identity when you create one, you must provide a credit card, but it won't be charged; it's always free to create and use bots with Microsoft Teams.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change so that the formatting is correct with this when viewed in the actual view. (so that it doesn't show up with the *)


3. You project needs to run with a configuration that matches your registered bot's configuration. To do this, you will need to update the web.config file:

Expand Down