Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GDB-10116]-Added-Private-Link-Support #37

Merged
3 commits merged into from
Apr 22, 2024
Merged

[GDB-10116]-Added-Private-Link-Support #37

3 commits merged into from
Apr 22, 2024

Conversation

ghost
Copy link

@ghost ghost commented Apr 12, 2024 •
edited by ghost
Loading

Description

  • Added support for the AWS PrivateLink service.
  • Added tags for the VPC
  • Added conditions for enable/disable AWS PrivateLink service.

Related Issues

GDB-10116

Changes

  • Support for the AWS PrivateLink service.
  • Tags for the VPC
  • Conditions to enable/disable AWS PrivateLink service.

Checklist

  • I have tested these changes thoroughly.
  • My code follows the project's coding style.
  • I have added appropriate comments to my code, especially in complex areas.
  • All new and existing tests passed locally.

@ghost ghost force-pushed the GDB-10116/Implement-PrivateLink-AWS-Terraform-Module branch 3 times, most recently from 056b5b7 to 34deff6 Compare April 16, 2024 09:36
@ghost ghost requested review from mihailradkov and viktor-ribchev April 16, 2024 09:38
@ghost ghost assigned mihailradkov and ghost and unassigned mihailradkov Apr 16, 2024
@ghost ghost marked this pull request as ready for review April 16, 2024 09:39
viktor-ribchev
viktor-ribchev reviewed Apr 16, 2024
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
@ghost ghost force-pushed the GDB-10116/Implement-PrivateLink-AWS-Terraform-Module branch 2 times, most recently from 6ee4308 to 1b22b2f Compare April 16, 2024 13:05
mihailradkov
mihailradkov reviewed Apr 18, 2024
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
@ghost ghost force-pushed the GDB-10116/Implement-PrivateLink-AWS-Terraform-Module branch from 9ef64a6 to 3aad70e Compare April 18, 2024 12:10
@ghost ghost force-pushed the GDB-10116/Implement-PrivateLink-AWS-Terraform-Module branch 3 times, most recently from 0809c75 to b96e087 Compare April 19, 2024 07:55
mihailradkov
mihailradkov reviewed Apr 19, 2024
View reviewed changes
modules/graphdb/nsg.tf Outdated Show resolved Hide resolved
variables.tf Show resolved Hide resolved
@ghost ghost force-pushed the GDB-10116/Implement-PrivateLink-AWS-Terraform-Module branch from d2b0d66 to 2e8d1d9 Compare April 22, 2024 06:22
@ghost ghost force-pushed the GDB-10116/Implement-PrivateLink-AWS-Terraform-Module branch from 2e8d1d9 to fe0861e Compare April 22, 2024 06:25
@ghost ghost requested a review from mihailradkov April 22, 2024 06:26
@ghost ghost merged commit fdbb415 into main Apr 22, 2024
3 checks passed
@ghost ghost deleted the GDB-10116/Implement-PrivateLink-AWS-Terraform-Module branch April 22, 2024 06:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihailradkov @viktor-ribchev @simonzhekoff