Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hardcoded band dim name #166

Merged
merged 2 commits into from
Nov 2, 2023
Merged

fix: hardcoded band dim name #166

merged 2 commits into from
Nov 2, 2023

Conversation

clausmichele
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 29, 2023 •
edited
Loading

Codecov Report

Merging #166 (0227bc8) into main (2c72406) will increase coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   79.66%   79.69%   +0.03%     
==========================================
  Files          29       29              
  Lines        1254     1256       +2     
==========================================
+ Hits          999     1001       +2     
  Misses        255      255
Files Coverage Δ
...cesses_dask/process_implementations/cubes/merge.py 96.20% <100.00%> (+0.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

GeraldIr
GeraldIr approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@GeraldIr GeraldIr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is tested, lgtm.

@clausmichele
Copy link
Member Author

@GeraldIr @ValentinaHutter please merge this, also needed for BIDS

@clausmichele clausmichele mentioned this pull request Nov 2, 2023
Merged
@ValentinaHutter ValentinaHutter merged commit 1d68c51 into Open-EO:main Nov 2, 2023
5 checks passed
@clausmichele clausmichele deleted the fix_merge_cubes branch November 2, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeraldIr GeraldIr GeraldIr approved these changes

@ValentinaHutter ValentinaHutter Awaiting requested review from ValentinaHutter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clausmichele @GeraldIr @ValentinaHutter