Remove macos-13 #299
Remove macos-13 #299
Conversation
| # if Python is <3.10 we can't use macos-latest which is arm64 | ||
| try: | ||
| if Version(item["python_version"]) < Version('3.10') and item["os"] == "macos-latest": | ||
| item["os"] = "macos-13" |
There was a problem hiding this comment.
I thought about not removing this for a while, but actually I think removing it and having the error be "can't find Python 3.9" is better than "huh what why is this on macos-13".
There was a problem hiding this comment.
But 3.9 is still available on macos-14, right? (or rather, added in actions/runner-images#9813)
There was a problem hiding this comment.
Ah, forgot again that that is the macos-large version. But then there won't actually be a free version available with Python < '3.11' anymore, unless I am missing something? Or they are yet adding it to macos-14 and/or -15; support policy indicates that 3.10 should still be available after 3.14 is out, though it does not explicitly guarantee this for all platforms...
| @@ -60,13 +60,6 @@ To not build any wheels: | |||
| targets: '' | |||
|
|
|||
| For additional configuration extra arguments can be passed by making a target a dictionary. | |||
| An example of this is specifying the runner for a target, such as building macos x86_64 wheels on native x86_64 runners: | |||
There was a problem hiding this comment.
Anyone got an idea of an example here which would still work?
|
|
||
| targets: | ||
| - target: cp311-macosx_x86_64 | ||
| runs-on: macos-13 |
There was a problem hiding this comment.
Do you want to swap out the example instead of removing it altogether?
|
The bigger issue I think is the arm non-arm switch, and that's what we run into regarding this upgrade for pytest-arraydiff (I mean the bug is downstream as the tests should handle the missing dependency, yet here we are): astropy/pytest-arraydiff#55 |
Fixes #298