-
Notifications
You must be signed in to change notification settings - Fork 16
Remove macos-13 #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove macos-13 #299
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,13 +60,6 @@ To not build any wheels: | |
targets: '' | ||
|
||
For additional configuration extra arguments can be passed by making a target a dictionary. | ||
An example of this is specifying the runner for a target, such as building macos x86_64 wheels on native x86_64 runners: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Anyone got an idea of an example here which would still work? |
||
|
||
.. code:: yaml | ||
|
||
targets: | ||
- target: cp311-macosx_x86_64 | ||
runs-on: macos-13 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you want to swap out the example instead of removing it altogether? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Preferably |
||
|
||
sdist | ||
^^^^^ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,6 @@ | |
# requires-python = "==3.12" | ||
# dependencies = [ | ||
# "click==8.2.1", | ||
# "packaging==25.0", | ||
# "pyyaml==6.0.2", | ||
# ] | ||
# /// | ||
|
@@ -12,7 +11,6 @@ | |
|
||
import click | ||
import yaml | ||
from packaging.version import InvalidVersion, Version | ||
|
||
|
||
@click.command() | ||
|
@@ -144,14 +142,6 @@ def get_matrix_item(env, global_libraries, global_string_parameters, | |
else: | ||
item["python_version"] = env.get("default_python") or default_python | ||
|
||
# if Python is <3.10 we can't use macos-latest which is arm64 | ||
try: | ||
if Version(item["python_version"]) < Version('3.10') and item["os"] == "macos-latest": | ||
item["os"] = "macos-13" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I thought about not removing this for a while, but actually I think removing it and having the error be "can't find Python 3.9" is better than "huh what why is this on macos-13". There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But 3.9 is still available on macos-14, right? (or rather, added in actions/runner-images#9813) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, forgot again that that is the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤷 lol |
||
except InvalidVersion: | ||
# python_version might be for example 'pypy-3.10' which won't parse | ||
pass | ||
|
||
# set name | ||
item["name"] = env.get("name") or f'{item["toxenv"]} ({item["os"]})' | ||
|
||
|
Uh oh!
There was an error while loading. Please reload this page.