Add quick filters on scenarios, simulations and atomic testing

[RomuDeuxfois]

Proposed changes

• Add quick filters on Create a new Inject, Scenarios, Simulations and Atomic Testings
• Create a new inject
• • Quick filters -> platform, kill chain phase, Target only players, Injector
• • Filters -> Label
• Scenario
• • Quick filters -> category, kill chain phase, tags
• • Filters -> name, severity, recurrence, updated at, platforms
• Simulation
• • Quick filters -> scenario, kill chain phases, tags
• • Filters -> name, start date, status, updated
• Atomic testing
• • Quick filters -> kill chain phases, tags
• • Filters -> title, updated, type

Related issues

• Implement filters on atomic testing, inject and payload lists #1294

[codecov]

Codecov Report

Attention: Patch coverage is 21.87500% with 50 lines in your changes missing coverage. Please review.

Project coverage is 30.11%. Comparing base (3d6774a) to head (e5520e6).
Report is 6 commits behind head on master.

Files with missing lines	Patch %	Lines
...rc/main/java/io/openbas/service/InjectService.java	0.00%	16 Missing ⚠️
.../io/openbas/rest/scenario/utils/ScenarioUtils.java	28.57%	9 Missing and 1 partial ⚠️
.../main/java/io/openbas/utils/CustomFilterUtils.java	0.00%	5 Missing ⚠️
...pi/src/main/java/io/openbas/utils/InjectUtils.java	44.44%	2 Missing and 3 partials ⚠️
...java/io/openbas/rest/inject/ExerciseInjectApi.java	0.00%	4 Missing ⚠️
...java/io/openbas/rest/inject/ScenarioInjectApi.java	0.00%	4 Missing ⚠️
...main/java/io/openbas/importer/V1_DataImporter.java	0.00%	3 Missing ⚠️
...ain/java/io/openbas/rest/exercise/ExerciseApi.java	50.00%	1 Missing ⚠️
.../java/io/openbas/service/AtomicTestingService.java	0.00%	1 Missing ⚠️
.../main/java/io/openbas/service/ScenarioService.java	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1352      +/-   ##
============================================
+ Coverage     28.84%   30.11%   +1.26%     
- Complexity     1323     1358      +35     
============================================
  Files           526      523       -3     
  Lines         13734    13716      -18     
  Branches        815      837      +22     
============================================
+ Hits           3962     4130     +168     
+ Misses         9587     9391     -196     
- Partials        185      195      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[damgouj]

Is it normal you keep the same API with pagination and not with pagination ? Can you merge the two or there is a reason that we keep the old one ?

[RomuDeuxfois]

Originally the API endpoints of all entities returned the entire DB table and everything was stored at the store level.

Going through pagination improves performance to return a more restricted list.

Unfortunately, there is still a lot of code to migrate to use the new endpoints and not all of it can be done in this task. But it’s something to keep in mind!

[RomuDeuxfois]

Comments taken into account.
Ready for a second round !