Improve validation error messages for oneOf #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bjwebb
force-pushed
the
cove-bods-16-oneof-only
branch
from
b5aa258
to
9fc8323
Compare
Bjwebb
added a commit
to openownership/lib-cove-bods
that referenced
this pull request
Mar 22, 2019
This makes the tests suitable for this PR: OpenDataServices/lib-cove#12 (instead of the larger OpenDataServices/lib-cove#8)
|
Here are some tests of this, in the lib-cove-bods repo: openownership/lib-cove-bods#8 |
odscjames
approved these changes
Mar 22, 2019
|
From reading the code it looks good; tho I have limited understanding of the details of this function. Good to see tests in another repo. It would be better if they were in this repo; but I accept given that we recently split up the code into repos and we didn't have time to look at tests fully at that time that that whole area is problematic at the moment anyway. So I've approved, but we should bear all this in mind for future work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the BODS specific oneOf work from this PR #8
Since this is BODS specific, we should be able to merge/release this without needing to consult other standards.