Add tests of improved validation error messages for oneOf #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a065870. This will be replaced with the version 0.1 schema on the master branch when that is merged in.
This makes the tests suitable for this PR: OpenDataServices/lib-cove#12 (instead of the larger OpenDataServices/lib-cove#8)
Bjwebb
changed the title
|
badfile_all_validation_errors.json seems to be a new file but I can't see it actually being used anywhere - have I missed something? I would put the upgrading of lib-cove to 0.5 in the changelog - we have to make sure that requirement is meet upstream when upgrading openownership/cove-bods and it would be good if it was clear in the Changelog. Also, that produces behaviour change in this repo in the types of error messages approved, it seems worth noting. |
Sorry, this is a holdover from the changes I removed from this branch. I have removed it.
Done. |
odscjames
approved these changes
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openownership/cove-bods#16
Depends on this lib-cove PR OpenDataServices/lib-cove#12