Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tested And Removed Commented Code #1401

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

danielshid
Copy link
Contributor

Description

I tested commented code in RadarChartComponent regarding cases where there is no data to display. To test the code I used invalid date ranges on both groups and meters. I came to the conclusion that it was safe to remove the commented code.

Fixes #1395

Type of change

  • Note merging this changes the database configuration.
  • This change requires a documentation update

Checklist

  • I have followed the OED pull request ideas
  • I have removed text in ( ) from the issue request
  • You acknowledge that every person contributing to this work has signed the OED Contributing License Agreement and each author is listed in the Description section.

Limitations

N/A

Copy link
Member

@huss huss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to @danielshid for taking on another issue. Review and testing found it works as desired. Also, thanks for fixing the formatting in a file that was outside the issue.

@huss huss merged commit edb2e8c into OpenEnergyDashboard:development Dec 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove check for readings unavailable
2 participants