Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tested And Removed Commented Code #1401

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Tested And Removed Commented Code #1401

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cc09f9
tested and removed commented out code
danielshid Dec 3, 2024
eaef31c
format document
danielshid Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/client/app/components/RadarChartComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export default function RadarChartComponent() {
'resetScale2d'];
const advancedButtons: Plotly.ModeBarDefaultButtons[] = ['select2d', 'lasso2d', 'autoScale2d', 'resetScale2d'];
// Manage button states with useState
const [listOfButtons, setListOfButtons] = React.useState(defaultButtons);
const [listOfButtons, setListOfButtons] = React.useState(defaultButtons);

// Add all valid data from existing meters to the radar plot
for (const meterID of selectedMeters) {
Expand All @@ -89,11 +89,6 @@ export default function RadarChartComponent() {
if (readingsData) {
const label = entity.identifier;
const colorID = meterID;
// TODO If we are sure the data is always defined then remove this commented out code.
// Be consistent for all graphing and groups below.
// if (readingsData.readings === undefined) {
// throw new Error('Unacceptable condition: readingsData.readings is undefined.');
// }
// Create two arrays for the distance (rData) and angle (thetaData) values. Fill the array with the data from the line readings.
// HoverText is the popup value show for each reading.
const thetaData: string[] = [];
Expand Down Expand Up @@ -146,9 +141,6 @@ export default function RadarChartComponent() {
if (readingsData) {
const label = entity.name;
const colorID = groupID;
// if (readingsData.readings === undefined) {
// throw new Error('Unacceptable condition: readingsData.readings is undefined.');
// }
// Create two arrays for the distance (rData) and angle (thetaData) values. Fill the array with the data from the line readings.
// HoverText is the popup value show for each reading.
const thetaData: string[] = [];
Expand Down
Loading