Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] mathematical model is inferred as energy #1844

Closed
5 tasks
stap-m opened this issue Apr 24, 2024 · 5 comments · Fixed by #1852
Closed
5 tasks

[Bug] mathematical model is inferred as energy #1844

stap-m opened this issue Apr 24, 2024 · 5 comments · Fixed by #1852
Assignees
@stap-m
Labels
[B] restructure Restructuring existing parts of the ontology
Milestone
oeo-release-2.3.0

Comments

@stap-m
Copy link
Contributor

stap-m commented Apr 24, 2024

Description of the issue

mathematical model is currently inferred as subclass of energy, which is a bug, obviously.

grafik

Ideas of solution

tbd

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words
@stap-m stap-m added [B] restructure Restructuring existing parts of the ontology To do Issues that haven't got discussed yet labels Apr 24, 2024
@stap-m stap-m self-assigned this Apr 24, 2024
@stap-m stap-m added this to the oeo-release-2.3.0 milestone Apr 24, 2024
@l-emele
Copy link
Contributor

l-emele commented Apr 24, 2024

I can confirm this bug and found a second, related one:
grafik

@l-emele
Copy link
Contributor

l-emele commented Apr 24, 2024

Both classes have has role axioms and we extended the domain of has role to energy or 'independent continuant'. Does that cause the problem?

@stap-m
Copy link
Contributor Author

stap-m commented Apr 24, 2024

That would also be my guess.

@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label Apr 24, 2024
@stap-m
Copy link
Contributor Author

stap-m commented Apr 25, 2024 •
edited
Loading

I think, we can solve it by the import of #1794 , adding the inverse object properties and giving 'role of' the domain 'role' and range 'continuant' (model is a continuant). Thus, we can specify which bearer each role has.

@stap-m
Copy link
Contributor Author

stap-m commented May 3, 2024

waits for #1838

@stap-m stap-m mentioned this issue May 6, 2024
Merged
5 tasks
stap-m added a commit that referenced this issue May 6, 2024
@stap-m
add inverse, domain and range to role of #1844
2a549dc
stap-m added a commit that referenced this issue May 6, 2024
@stap-m
update inverse of has characteristic #1844
2854301
stap-m added a commit that referenced this issue May 6, 2024
@stap-m
add model role axiom #1844
56a662f
stap-m added a commit that referenced this issue May 6, 2024
@stap-m
remove domain from has charachteristic, see annotation of characteris…
e67c524 
…tic of #1844
stap-m added a commit that referenced this issue May 6, 2024
@stap-m
remove inverse relation between has bearer and has charachteristic #1844
7f6b5ec
@stap-m stap-m mentioned this issue May 6, 2024
Merged
5 tasks
stap-m added a commit that referenced this issue May 8, 2024
@stap-m
Merge pull request #1852 from OpenEnergyPlatform/feature-1844-bug-fix…
2fb0cbd 
…-role

bug fix with roles #1844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stap-m stap-m

Labels
[B] restructure Restructuring existing parts of the ontology
Projects
Issues
Status: Done
Milestone
oeo-release-2.3.0
Development

Successfully merging a pull request may close this issue.

bug fix with roles #1844 OpenEnergyPlatform/ontology
2 participants
@l-emele @stap-m