Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Characteristic of #1838

Merged
merged 7 commits into from
May 6, 2024
Merged

Added Characteristic of #1838

merged 7 commits into from
May 6, 2024

Conversation

areleu
Copy link
Contributor

@areleu areleu commented Apr 18, 2024

Summary of the discussion

Deals with #1794

Type of change (CHANGELOG.md)

Add

Workflow checklist

Automation

Closes #1794

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@areleu
Copy link
Contributor Author

areleu commented Apr 18, 2024

When running the script a bunch of annotations from has part came through, is it something to worry about?

@areleu areleu requested a review from stap-m April 18, 2024 10:51
@stap-m
Copy link
Contributor

stap-m commented Apr 18, 2024

grafik
Very interesting comment, btw. This could spare us some headaches...

@stap-m
Copy link
Contributor

stap-m commented Apr 18, 2024

When running the script a bunch of annotations from has part came through, is it something to worry about?

IAO and RO both import has part from BFO. We should delete it again from the RO import to avoid duplicate annotations.
grafik

@areleu
Copy link
Contributor Author

areleu commented Apr 19, 2024

Now this, some of the super classses of characteristic of are coming with the import, should we import it without its tree?

@stap-m
Copy link
Contributor

stap-m commented Apr 22, 2024

Now this, some of the super classses of characteristic of are coming with the import, should we import it without its tree?

Yes, I think we don't need the full hierarchy.

@stap-m stap-m requested review from l-emele and nelekoehler May 6, 2024 09:25
@stap-m
Copy link
Contributor

stap-m commented May 6, 2024

I have the impression that we can improve the import. However this requires some more time.
#1844 waits for the completion of this PR. Therefore, if there are no severe bugs, I'd like to merge this now. @areleu @nelekoehler @l-emele can someone else take a look please?

CHANGELOG.md Outdated Show resolved Hide resolved
@nelekoehler
Copy link
Contributor

The imported object properties look good to me. I didn't recognize any bugs concerning them.

@stap-m stap-m merged commit 10b40f5 into dev May 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

import characteristic of from RO
3 participants