Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix with roles #1844 #1852

Merged
merged 7 commits into from
May 8, 2024
Merged

bug fix with roles #1844 #1852

merged 7 commits into from
May 8, 2024

Conversation

stap-m
Copy link
Contributor

@stap-m stap-m commented May 6, 2024

Summary of the discussion

Bug fix: models are inferred as energies because of 'has bearer'

Type of change (CHANGELOG.md)

Update

  • add inverse, domain to role of
  • make has characteristic and characteristic of inverses, remove inverse off of has bearer
  • add axiom to model role

Workflow checklist

Automation

Closes #1844

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-shared changes the oeo-shared module label May 6, 2024
@stap-m stap-m marked this pull request as ready for review May 6, 2024 11:18
@stap-m stap-m requested a review from l-emele May 6, 2024 11:19
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug is gone so I approve:
grafik

@stap-m stap-m merged commit 2fb0cbd into dev May 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-shared changes the oeo-shared module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] mathematical model is inferred as energy
2 participants