Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix with roles #1844 #1852

Merged
merged 7 commits into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ and the versioning aims to respect [Semantic Versioning](http://semver.org/spec/
### Changed
- has documentation quality (#1834)
- emission factor, emission rate, greenhouse gas emission rate, CO2 emission rate, carbon dioxide equivalent quantity value (#1846)
- has bearer, has characteristic, characteristic of, role of, model role (#1852)

### Removed

Expand Down
34 changes: 34 additions & 0 deletions src/ontology/edits/oeo-import-edits.owl
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,27 @@ pull request https://github.com/OpenEnergyPlatform/ontology/pull/1086</obo:IAO_0



<!-- http://purl.obolibrary.org/obo/RO_0000052 -->

<owl:ObjectProperty rdf:about="http://purl.obolibrary.org/obo/RO_0000052">
<owl:inverseOf rdf:resource="http://purl.obolibrary.org/obo/RO_0000053"/>
<obo:IAO_0000233>add inverse:
issue: https://github.com/OpenEnergyPlatform/ontology/issues/1844
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1852</obo:IAO_0000233>
</owl:ObjectProperty>



<!-- http://purl.obolibrary.org/obo/RO_0000053 -->

<owl:ObjectProperty rdf:about="http://purl.obolibrary.org/obo/RO_0000053">
<obo:IAO_0000233>update inverse:
issue: https://github.com/OpenEnergyPlatform/ontology/issues/1844
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1852</obo:IAO_0000233>
</owl:ObjectProperty>



<!-- http://purl.obolibrary.org/obo/RO_0000056 -->

<owl:ObjectProperty rdf:about="http://purl.obolibrary.org/obo/RO_0000056">
Expand Down Expand Up @@ -152,6 +173,19 @@ pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1225</obo:IAO_



<!-- http://purl.obolibrary.org/obo/RO_0000081 -->

<owl:ObjectProperty rdf:about="http://purl.obolibrary.org/obo/RO_0000081">
<owl:inverseOf rdf:resource="http://purl.obolibrary.org/obo/RO_0000087"/>
<rdfs:domain rdf:resource="http://purl.obolibrary.org/obo/BFO_0000023"/>
<rdfs:range rdf:resource="http://purl.obolibrary.org/obo/BFO_0000002"/>
<obo:IAO_0000233>add domain and range:
issue: https://github.com/OpenEnergyPlatform/ontology/issues/1844
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1852</obo:IAO_0000233>
</owl:ObjectProperty>



<!-- http://purl.obolibrary.org/obo/RO_0000085 -->

<owl:ObjectProperty rdf:about="http://purl.obolibrary.org/obo/RO_0000085">
Expand Down
37 changes: 15 additions & 22 deletions src/ontology/edits/oeo-shared.omn
Original file line number Diff line number Diff line change
Expand Up @@ -139,25 +139,19 @@ ObjectProperty: <http://purl.obolibrary.org/obo/RO_0000053>
Annotations:
<http://purl.obolibrary.org/obo/IAO_0000118> "has characteristic"

Domain:

Annotations: <http://purl.obolibrary.org/obo/IAO_0000233> "issue: https://github.com/OpenEnergyPlatform/ontology/issues/973
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/985"
OEO_00000150 or <http://purl.obolibrary.org/obo/BFO_0000004>

Range:
<http://purl.obolibrary.org/obo/BFO_0000020>

InverseOf:
OEO_00010121


ObjectProperty: <http://purl.obolibrary.org/obo/RO_0000056>


ObjectProperty: <http://purl.obolibrary.org/obo/RO_0000057>


ObjectProperty: <http://purl.obolibrary.org/obo/RO_0000081>


ObjectProperty: <http://purl.obolibrary.org/obo/RO_0000085>


Expand All @@ -172,9 +166,6 @@ ObjectProperty: <http://purl.obolibrary.org/obo/RO_0000087>
issue: https://github.com/OpenEnergyPlatform/ontology/issues/1030
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1101"

Domain:
OEO_00000150 or <http://purl.obolibrary.org/obo/BFO_0000004>


ObjectProperty: <http://purl.obolibrary.org/obo/RO_0000091>

Expand Down Expand Up @@ -616,7 +607,11 @@ pull request: https://github.com/OpenEnergyPlatform/ontology/pull/985

correct definition with respect to energy:
issue: https://github.com/OpenEnergyPlatform/ontology/issues/1305
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1484",
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1484

remove inverse:
issue: https://github.com/OpenEnergyPlatform/ontology/issues/1844
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1852",
rdfs:label "has bearer"@en

Domain:
Expand All @@ -625,9 +620,6 @@ pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1484",
Range:
OEO_00000150 or <http://purl.obolibrary.org/obo/BFO_0000004>

InverseOf:
<http://purl.obolibrary.org/obo/RO_0000053>


ObjectProperty: OEO_00010231

Expand Down Expand Up @@ -1209,10 +1201,6 @@ Class: <http://purl.obolibrary.org/obo/BFO_0000019>

Class: <http://purl.obolibrary.org/obo/BFO_0000020>

SubClassOf:
OEO_00010121 some
(OEO_00000150 or <http://purl.obolibrary.org/obo/BFO_0000004>)


Class: <http://purl.obolibrary.org/obo/BFO_0000023>

Expand Down Expand Up @@ -1721,11 +1709,16 @@ Class: OEO_00020353
Annotations:
<http://purl.obolibrary.org/obo/IAO_0000115> "A model role is a a role of a continuant for representing a system and its behaviours in a simplified or idealised way.",
<http://purl.obolibrary.org/obo/IAO_0000233> "issue: https://github.com/OpenEnergyPlatform/ontology/issues/1444
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1707",
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1707

add axiom:
issue: https://github.com/OpenEnergyPlatform/ontology/issues/1844
pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1852",
rdfs:label "model role"@en

SubClassOf:
<http://purl.obolibrary.org/obo/BFO_0000023>
<http://purl.obolibrary.org/obo/BFO_0000023>,
<http://purl.obolibrary.org/obo/RO_0000081> some OEO_00020352


Class: OEO_00030019
Expand Down
Loading