Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin/feature 1471 german labels 1 #1862

Merged
merged 45 commits into from
Jun 11, 2024

Conversation

vismayajochem
Copy link
Contributor

@vismayajochem vismayajochem commented Jun 5, 2024

Summary of the discussion

I implemented several new labels please check if everything is correct. To check see also the google doc https://docs.google.com/spreadsheets/d/1snsx6zF8dqXGM9WCX0EckrdGnorrB9lMnvdvP2fx9ZQ/edit#gid=687082420

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@vismayajochem vismayajochem self-assigned this Jun 5, 2024
@github-actions github-actions bot added oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module oeo-sector oeo-shared changes the oeo-shared module oeo-social changes the oeo-social module labels Jun 5, 2024
@vismayajochem
Copy link
Contributor Author

I added the @en to the english alternative labels. Is it ok as it is now @l-emele ?

Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just fixed two typos and committed.

Now everything looks fine and I thus approve this PR.

Thanks for implementing!

@vismayajochem vismayajochem merged commit de2f353 into dev Jun 11, 2024
4 checks passed
@vismayajochem vismayajochem deleted the origin/feature-1471-german-labels_1 branch June 11, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module oeo-sector oeo-shared changes the oeo-shared module oeo-social changes the oeo-social module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants