Feature 1471 german labels 2 #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-emele
reviewed
Jun 20, 2024
l-emele
reviewed
Jun 20, 2024
l-emele
reviewed
Jun 20, 2024
l-emele
reviewed
Jun 20, 2024
l-emele
reviewed
Jun 20, 2024
src/ontology/edits/oeo-social.omn
Outdated
| @@ -2399,6 +2428,8 @@ pull request: https://github.com/OpenEnergyPlatform/ontology/pull/944 | |||
| move govern axioms to oeo-shared-axioms | |||
| issue: https://github.com/OpenEnergyPlatform/ontology/issues/1399 | |||
| pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1724", | |||
| rdfs:comment "EU-EHS"@de, | |||
| rdfs:comment "Emissionshandelssystem der Europäischen Union"@de, | |||
There was a problem hiding this comment.
These two should be implemented as alternative label and not as rdfs:comment
l-emele
reviewed
Jun 20, 2024
src/ontology/edits/oeo-social.omn
Outdated
| @@ -2457,6 +2490,7 @@ pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1462 | |||
| move axiom to oeo-shared-axioms | |||
| issue: https://github.com/OpenEnergyPlatform/ontology/issues/1399 | |||
| pull request: https://github.com/OpenEnergyPlatform/ontology/pull/1724", | |||
| rdfs:comment "EU-Klimapolitik"@de, | |||
There was a problem hiding this comment.
Should be alternative label instead of rdf:comments
l-emele
requested changes
Jun 20, 2024
Co-authored-by: l-emele <[email protected]>
Co-authored-by: l-emele <[email protected]>
Co-authored-by: l-emele <[email protected]>
Co-authored-by: l-emele <[email protected]>
vismayajochem
commented
Jun 24, 2024
|
I also updated the google doc sheet and implemented the suggested changes from @l-emele |
Co-authored-by: Vismaya RLI <[email protected]>
l-emele
reviewed
Jun 25, 2024
l-emele
approved these changes
Jun 25, 2024
github-actions
bot
added
oeo-model
|
I just say that this PR was behind the dev branch, so I merged dev and fixed resulting merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
I implemented several new german alternative labels, please check if everything is correct. To check see also the google doc https://docs.google.com/spreadsheets/d/1snsx6zF8dqXGM9WCX0EckrdGnorrB9lMnvdvP2fx9ZQ/edit#gid=687082420
I also implemented the english language tag to already existing english alternative labels.
Workflow checklist
Automation
Closes #
PR-Assignee
term tracker itemReviewer