Attempt to migrate from Travis to GitHub Actions #302
Conversation
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Also try the non-Git codespell
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Please check this manually before merging
Manufacturer updates for GitHub Actions
|
This gets us back to at least having some basic CI again... |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| task: [data-check, codespell] |
There was a problem hiding this comment.
Interesting use of matrix builds. I would've expected several steps/jobs instead of tasks defined by a matrix but why not?
There was a problem hiding this comment.
This was simply to get it the closest to our existing Travis setup, given it currently just calls the old script for that.
I think if you had steps/jobs, then where you've got say json-spec needed on more than one, you'd have to duplicate the install instructions (or install it even for the builds which don't need it, which doesn't seem very efficient to me.
| if [ "$TASK" = "pychecker" -o "$TASK" = "pychecker-wip" ]; then pip install http://sourceforge.net/projects/pychecker/files/pychecker/0.8.19/pychecker-0.8.19.tar.gz/download; fi | ||
| #if [ "$TASK" = "codespell" ]; then pip install git+https://github.com/codespell-project/codespell.git; fi | ||
| if [ "$TASK" = "codespell" ]; then pip install codespell; fi | ||
| sudo apt-get install xvfb |
There was a problem hiding this comment.
Why not have those four apt install lines merged into one line with all packages installed in one go?
There was a problem hiding this comment.
Yeah that's a fair point. I think I was running them individually as the presence of a package already being installed broke the whole build!
First bit done for now...