Attempt to migrate from Travis to GitHub Actions #302
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # GitHub Action to compile and test | ||
| name: test | ||
| on: [push, pull_request] | ||
| jobs: | ||
| test: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| task: [data-check, codespell] | ||
| #spellintian, nosetests, karma, lint, closure-compiler, | ||
| steps: | ||
| - uses: actions/checkout@master | ||
| - name: Install dependencies | ||
| env: | ||
| TASK: ${{ matrix.task }} | ||
| run: | | ||
| if [ "$TASK" = "nosetests" -o "$TASK" = "flake8" -o "$TASK" = "flake8-wip" ]; then pip install json-spec; fi | ||
| if [ "$TASK" = "karma" -o "$TASK" = "lint" -o "$TASK" = "closure-compiler" ]; then npm install -g grunt-cli; fi | ||
| if [ "$TASK" = "karma" -o "$TASK" = "lint" -o "$TASK" = "closure-compiler" ]; then npm install; fi | ||
| if [ "$TASK" = "flake8" -o "$TASK" = "flake8-wip" ]; then pip install flake8; fi | ||
| # If this causes SSL errors, then Sourceforge is probably in disaster recovery mode and needing Javascript. Could switch to a specific mirror, e.g. kent.dl.sourceforge.net | ||
| if [ "$TASK" = "pychecker" -o "$TASK" = "pychecker-wip" ]; then pip install http://sourceforge.net/projects/pychecker/files/pychecker/0.8.19/pychecker-0.8.19.tar.gz/download; fi | ||
| #if [ "$TASK" = "codespell" ]; then pip install git+https://github.com/codespell-project/codespell.git; fi | ||
| if [ "$TASK" = "codespell" ]; then pip install codespell; fi | ||
| sudo apt-get install xvfb | ||
|
There was a problem hiding this comment. Why not have those four There was a problem hiding this comment. Yeah that's a fair point. I think I was running them individually as the presence of a package already being installed broke the whole build! |
||
| sudo apt-get install libhtml-parser-perl | ||
| sudo apt-get install lintian | ||
| sudo apt-get install moreutils | ||
| - uses: codespell-project/codespell-problem-matcher@v1 | ||
| - name: Test | ||
| env: | ||
| TASK: ${{ matrix.task }} | ||
| run: | | ||
| bash -ex .travis-ci.sh | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting use of matrix builds. I would've expected several steps/jobs instead of tasks defined by a matrix but why not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was simply to get it the closest to our existing Travis setup, given it currently just calls the old script for that.
I think if you had steps/jobs, then where you've got say json-spec needed on more than one, you'd have to duplicate the install instructions (or install it even for the builds which don't need it, which doesn't seem very efficient to me.