-
Notifications
You must be signed in to change notification settings - Fork 61
Parser #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser #270
Conversation
* fix ex.message => ex.msg
* fix ex.message => ex.msg
The output of `getComponentModifierValue` is changed so we don't need to strip the result. And the output of `getExtendsModifierValue` is changed in OpenModelica/OpenModelica#13533 Removed `_ask_with_fallback` and moved the fallback code to `sendExpression`
@syntron I removed I think we should also remove all the APIs and |
@adeas31 I just added all the commits I prepared for OMCSession.py (see PR #275). It further simplifies OMCSessionBase such that is an independend class which can be used to query OMC based on a session (= OMCSessionZMQ). As side effect, this class could later be removed - however, at the moment it is as simple as possible and - thus - perhaps still useful. Some small additional cleanups:
|
just noted: this now includes PR #272 ... if needed I can split this put again ... |
d96bc10
to
0be8325
Compare
Lets keep the PRs simple. Adding small chunks of code is better than adding huge block of code. Please split and make several PRs if possible. |
I restored the state of this PR before my change - the modified parser branch is kept in my fork as parserOLD and as PR #280, #281 and #282 |
There are two parsers for OM return values which are used in OMCSessionBase. This PR tries to clean up their usage - use only a single entry point for each - and add some additional cleanup: