Skip to content

[OMCSessionBase.ask()] define opt as list #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025

Conversation

syntron
Copy link
Contributor

@syntron syntron commented May 2, 2025

define argument opt for OMCSessionBase._ask() as list - build string out of the content in a controlled way (this was part of the extended version of PR #270)

additional changes:

  • rename ask() => _ask() to indicate that this is a function internal for the class

This was referenced May 2, 2025
@syntron syntron force-pushed the OMCSessionBase_opt_as_list branch 2 times, most recently from adaf077 to c4f2362 Compare May 3, 2025 19:34
@syntron syntron mentioned this pull request May 7, 2025
@syntron syntron force-pushed the OMCSessionBase_opt_as_list branch from c4f2362 to bcfeb3c Compare May 8, 2025 19:22
@syntron
Copy link
Contributor Author

syntron commented May 9, 2025

The failing test is due to a timeout (The job running on runner GitHub Actions 3 has exceeded the maximum execution time of 30 minutes.) - is there a possibility to restart the test?

@adeas31
Copy link
Member

adeas31 commented May 9, 2025

I restarted it but you can always force push to rerun the tests.

@syntron
Copy link
Contributor Author

syntron commented May 9, 2025

@adeas31 I thought so but was searching for an easier solution ...

@adeas31 adeas31 merged commit a6d877d into OpenModelica:master May 12, 2025
5 checks passed
@syntron syntron deleted the OMCSessionBase_opt_as_list branch May 12, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants