Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datalad): Separate validator process construction from wait, allowing error logging #3048

Merged
merged 2 commits into from
May 8, 2024

fix(test): Mock Popen() instead of run()

ce8ee30
Select commit
Loading
Failed to load commit list.
Merged

fix(datalad): Separate validator process construction from wait, allowing error logging #3048

fix(test): Mock Popen() instead of run()
ce8ee30
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded May 8, 2024 in 0s

76.92% of diff hit (target 42.48%)

View this Pull Request on Codecov

76.92% of diff hit (target 42.48%)

Annotations

Check warning on line 44 in services/datalad/datalad_service/tasks/validator.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

services/datalad/datalad_service/tasks/validator.py#L43-L44 

Added lines #L43 - L44 were not covered by tests

Check warning on line 77 in services/datalad/datalad_service/tasks/validator.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

services/datalad/datalad_service/tasks/validator.py#L77 

Added line #L77 was not covered by tests
View more details on Codecov