Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datalad): Separate validator process construction from wait, allowing error logging #3048

Merged
merged 2 commits into from
May 8, 2024

fix(test): Mock Popen() instead of run()

ce8ee30
Select commit
Loading
Failed to load commit list.
Merged

fix(datalad): Separate validator process construction from wait, allowing error logging #3048

fix(test): Mock Popen() instead of run()
ce8ee30
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 8, 2024 in 0s

43.44% (+0.96%) compared to cd5c1e0

View this Pull Request on Codecov

43.44% (+0.96%) compared to cd5c1e0

Details

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 43.44%. Comparing base (cd5c1e0) to head (ce8ee30).
Report is 2 commits behind head on master.

Files Patch % Lines
...ervices/datalad/datalad_service/tasks/validator.py 76.92% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3048      +/-   ##
==========================================
+ Coverage   42.48%   43.44%   +0.96%     
==========================================
  Files         601      601              
  Lines       37971    37970       -1     
  Branches     1113     1147      +34     
==========================================
+ Hits        16131    16496     +365     
+ Misses      21624    21267     -357     
+ Partials      216      207       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov