feat(app): Add Neurosift viewer for EDF and NWB files

[nellh]

Implementation of #3186 using the iframe approach.

[codecov]

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.44%. Comparing base (1c1e0d3) to head (149a8ea).
Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
...app/src/scripts/dataset/files/file-viewer-type.jsx	60.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3187      +/-   ##
==========================================
+ Coverage   43.10%   44.44%   +1.34%     
==========================================
  Files         547      592      +45     
  Lines       36178    37861    +1683     
  Branches     1128     1131       +3     
==========================================
+ Hits        15595    16829    +1234     
- Misses      20383    20832     +449     
  Partials      200      200              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[magland]

Thanks @nellh

This won't work as is for NWB files. The URL for those looks a bit different:

https://neurosift.app/?p=/nwb&url=https://api.dandiarchive.org/api/assets/027567cf-e9e0-4aba-83c0-ef2d22c8c1b7/download/

Notice the p=/nwb instead of p=/edf

[magland]

I wonder what's the best way to select the height. Is the plan to just fix it as something sensible?

[nellh]

Thanks @nellh

This won't work as is for NWB files. The URL for those looks a bit different:

https://neurosift.app/?p=/nwb&url=https://api.dandiarchive.org/api/assets/027567cf-e9e0-4aba-83c0-ef2d22c8c1b7/download/

Notice the p=/nwb instead of p=/edf

Thanks, fixed!

I wonder what's the best way to select the height. Is the plan to just fix it as something sensible?

I set it to 50% viewport height as this is what our HTML iframe viewer was doing already and generally gives a good amount of space for the viewer without using a static height.

[magland]

This is great, thanks @nellh . When will this go live?

[nellh]

This is great, thanks @nellh . When will this go live?

It will be included in the next OpenNeuro release, aiming to release early next week.

[magland]

@nellh I think there's a problem here. It seems that when you visit the page of an EDF file, the entire file gets automatically downloaded to the browser before the iframe is rendered. This is probably because that's how other file types are handled. But in this case, we don't need the file to be downloaded - and that's the point of neurosift - that's it's lazy-loading. Sometimes the files can be quite large.