Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Prevent loading files for viewers with built in data transfer #3226

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented Nov 19, 2024

Skip data requests for some files when the viewer includes data loading.

Fixes #3225

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 45.66%. Comparing base (ae8103c) to head (e78f2a5).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...nneuro-app/src/scripts/dataset/files/file-view.jsx 14.28% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3226   +/-   ##
=======================================
  Coverage   45.65%   45.66%           
=======================================
  Files         594      595    +1     
  Lines       37999    38013   +14     
  Branches     1161     1167    +6     
=======================================
+ Hits        17348    17357    +9     
- Misses      20454    20459    +5     
  Partials      197      197           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@nellh nellh force-pushed the 3225-file-viewer-load-fix branch from 8f9690f to e78f2a5 Compare November 19, 2024 21:06
@nellh nellh merged commit 6278e53 into master Nov 19, 2024
15 checks passed
@nellh nellh deleted the 3225-file-viewer-load-fix branch November 19, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File viewer loads unused data for NIfTI, NWB, and EDF files
2 participants