Allow to set agenda item tags with agenda_tag_ids #1832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reiterl
added
the
enhancement
jsangmeister
requested changes
Jul 28, 2023
There was a problem hiding this comment.
The topic.update action doesn't have set tag_ids anymore and no agenda_tag_ids. So these tests are not needed anymore.
There was a problem hiding this comment.
Then please transfer these tests to the agenda item update tests. They do not only test the action, but also the relation and action handling and should therefore not be removed.
There was a problem hiding this comment.
Okay, I have moved the removed tag_ids update to agenda_item.
Remove topic/tag_ids because it is not used in the client.
reiterl
force-pushed
the
update-topic-create
branch
from
87e72f3
to
7a301c9
Compare
jsangmeister
approved these changes
Jul 31, 2023
peb-adr
added a commit
to peb-adr/openslides-backend
that referenced
this pull request
Aug 22, 2023
* commit '6195994174e549f3c7f16ae648027e557eda5fcc': (99 commits) Add check to forbid self vote delegation (OpenSlides#1875) Fix agenda item update (OpenSlides#1861) Fix delete user with poll candidate (OpenSlides#1872) Fix of a problem with calculated user/committee_ids (OpenSlides#1859) Add default to meeting/users_pdf_wlan_encryption (OpenSlides#1863) Add meeting_user_id to user.create action result (OpenSlides#1866) change saml_private_key type to text (OpenSlides#1860) Move additional model code to mixins (OpenSlides#1808) Add saml_id to the account import actions (OpenSlides#1821) Fix relation handling with calculated fields handler (OpenSlides#1839) Extend project automation Update GitHub actions (OpenSlides#1822) Fix for a key error problem in speaker create (OpenSlides#1838) Allow to set agenda item tags with agenda_tag_ids (OpenSlides#1832) Add two options to workflow import (OpenSlides#1833) LOS restrict point of order submission to open lists (OpenSlides#1830) Revert "Add an unique check for motion_category.prefix. (OpenSlides#1626)" (OpenSlides#1828) Update gunicorn & datastore (OpenSlides#1825) Rename database env vars & update dependencies (OpenSlides#1800) Add tag_ids to topic.create (OpenSlides#1819) ...
peb-adr
added a commit
that referenced
this pull request
Sep 6, 2023
* commit '9ca701b83a47b2b35cba4a6a85393d45e98807da': (96 commits) Update linear sort error messages (#1891) Use automation access token in repository_dispatch (#1890) fix key error in get_user_scope (#1887) Fix reachability of actions in dev mode (#1818) Catch internal auth password decoding error (#1817) Add check to forbid self vote delegation (#1875) Fix agenda item update (#1861) Fix delete user with poll candidate (#1872) Fix of a problem with calculated user/committee_ids (#1859) Add default to meeting/users_pdf_wlan_encryption (#1863) Add meeting_user_id to user.create action result (#1866) change saml_private_key type to text (#1860) Move additional model code to mixins (#1808) Add saml_id to the account import actions (#1821) Fix relation handling with calculated fields handler (#1839) Extend project automation Update GitHub actions (#1822) Fix for a key error problem in speaker create (#1838) Allow to set agenda item tags with agenda_tag_ids (#1832) Add two options to workflow import (#1833) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove topic/tag_ids because it is not used in the client.
Update topic.create.