configs: use single hartid #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, we use HartIds: Seq[Int] in L2Param. However, it only contain one element since the code is copied from L3, and L2 is now private to a core, which confuses some developers and causes a bug [1]. To prevent it from happening again, we should use a single HartId here and refactor many of its consumers to use a single HartId. [1] OpenXiangShan/XiangShan#2966 (comment) Signed-off-by: Yangyu Chen <[email protected]>
|
LGTM. Wait for HuanCun. |
linjuanZ
approved these changes
May 11, 2024
Signed-off-by: Yangyu Chen <[email protected]>
cyyself
force-pushed
the
tmp_use_single_hartid
branch
from
85cb1df to
b6b0147
Compare
Ivyfeather
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, we use HartIds: Seq[Int] in L2Param. However, it will only contain one element since the code is copied from L3, and L2 is now private to a core, which confuses some developers and causes a bug [1]. To prevent it from happening again, we should use a single HartId here and refactor many of its consumers to use a single HartId.
[1] OpenXiangShan/XiangShan#2966 (comment)