Squash replay: optimized by NEMU store log #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change should be supported by NEMU PR OpenXiangShan/NEMU#265. |
klin02
force-pushed
the
replay-store-log
branch
from
18ed755 to
e065924
Compare
klin02
force-pushed
the
replay-store-log
branch
2 times, most recently
from
0841871 to
71bc711
Compare
|
When bump to XiangShan with this commit, we should bump ready-to-run at the same time. |
poemonsense
approved these changes
Feb 28, 2024
Previous we use naive memcpy for NEMU memory snapshot. Now we complete more efficient memory snapshot and recovery with NEMU store log. Call ref_store_log_reset and set_store_log, then we can record origin data of every pmem_write for this execution. When REF and DUT comparation trigger error, call ref_store_log_restore, then memory will recover in reverse order. ENABLE_STORE_LOG macro added to config.
Now we has 3 Memory, DUT REF Golden. When Squash replay, DUT will transmit unsquashed DiffState which are already generated and stored, and we will reset REF and Golden Memory to process these states. Overall, DUT memory doesn't need to restore. REF and Golden Memory will be restored by store_log.
klin02
force-pushed
the
replay-store-log
branch
from
71bc711 to
c750746
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous we use naive memcpy for NEMU memory snapshot. Now we complete more efficient memory snapshot and recovery with NEMU store log.
Call ref_store_log_reset and set_store_log, then we can record origin data of every pmem_write for this execution. When REF and DUT comparation trigger error, call ref_store_log_restore, then memory will recover in reverse order.
ENABLE_STORE_LOG macro added to config.