vcs: add dramsim on emu run #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaokamikami
force-pushed
the
master
branch
2 times, most recently
from
6f67cd2 to
8ec5cae
Compare
klin02
reviewed
Mar 7, 2024
src/test/csrc/common/ram.cpp
Outdated
| @@ -440,6 +440,8 @@ void dramsim3_init() { | |||
|
|
|||
| assert(dram == NULL); | |||
| dram = new ComplexCoDRAMsim3(DRAMSIM3_CONFIG, DRAMSIM3_OUTDIR); | |||
| if (dram == NULL) | |||
There was a problem hiding this comment.
Is it necessary? Seems we call dramsim same as emu. No need to change the common interface.
There was a problem hiding this comment.
Prevents references to null Pointers from causing Paladin to crash,If you don't think this is necessary, I can add a macro definition to enable checks on Paladin
klin02
reviewed
Mar 7, 2024
src/test/csrc/vcs/vcs_main.cpp
Outdated
| @@ -199,6 +205,9 @@ extern "C" void simv_nstep(uint8_t step) { | |||
| extern "C" uint8_t simv_nstep(uint8_t step) { | |||
| if (difftest == NULL) | |||
| return 0; | |||
| #ifdef WITH_DRAMSIM3 | |||
There was a problem hiding this comment.
If you want to trigger simv_tick every cycle. Sperate it for single interface, rather than leave it everywhere.
xiaokamikami
force-pushed
the
master
branch
5 times, most recently
from
c58f10e to
ff28020
Compare
xiaokamikami
force-pushed
the
master
branch
3 times, most recently
from
6f695c2 to
2cfa5dc
Compare
klin02
reviewed
Mar 13, 2024
src/test/csrc/vcs/vcs_main.cpp
Outdated
| static uint8_t simv_result = SIMV_RUN; | ||
| #ifdef WITH_DRAMSIM3 | ||
| extern "C" void simv_tick() { | ||
| #ifdef CONFIG_DIFFTEST_DEFERRED_RESULT |
There was a problem hiding this comment.
No need to check simv_result and difftest here. You can check whether dram is NULL in dramsim3_step
klin02
reviewed
Mar 13, 2024
src/test/csrc/vcs/vcs_main.cpp
Outdated
| @@ -190,7 +222,6 @@ void simv_finish() { | |||
| simMemory = nullptr; | |||
| } | |||
|
|
|||
| static uint8_t simv_result = SIMV_RUN; | |||
klin02
reviewed
Mar 13, 2024
src/test/csrc/vcs/vcs_main.cpp
Outdated
| @@ -152,6 +162,14 @@ extern "C" uint8_t simv_step() { | |||
| if (max_instrs != 0) { // 0 for no limit | |||
| auto trap = difftest[0]->get_trap_event(); | |||
| if (max_instrs < trap->instrCnt) { | |||
| if (ckpt_item != NULL) { | |||
There was a problem hiding this comment.
Seems unexpected changes for dramsim? May you only push master branch on your fork repo
xiaokamikami
force-pushed
the
master
branch
2 times, most recently
from
f021b6d to
766c123
Compare
klin02
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for enabling dramsim3 programs to run on Paradine. DRAMSIM3_HOME Note: Recompile dramsim3 on Paladin and set DRAMSIM3_HOME, then add DRAMSIM3_HOME to LD_LIBRARY_PATH so that it links to the dynamic library correctly