Fix Palladium CFLAGS for path parsing #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previou for Verilator/VCS, SIM_CXXFLAGS will be passed twice, so we use \\\" for path, make it visible as " inside the code. For Palladium, we pass these CXX_FLAGS directly to gcc, so we should replace \\\" with \", to make it treat correctly in compilation.
klin02
changed the title
poemonsense
approved these changes
Mar 13, 2024
klin02
added a commit
that referenced
this pull request
Mar 18, 2024
Previous change #312 has an extra space, we cause error in path parsing, this change fixs it.
klin02
added a commit
that referenced
this pull request
Mar 19, 2024
Previous change #312 has an extra space, which cause error in path parsing, this change fixs it. The usage of subst is $(subst <from>,<to>,<text>), redundant space is not allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previou for Verilator/VCS, SIM_CXXFLAGS will be passed twice, so we use \" for path, make it visible as " inside the code.
For Palladium, we pass these CFLAGS directly to gcc, so we should replace \" with ", to make it treat correctly in compilation.