vcs: add finish_device for simv_finish #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please format PR title and message |
klin02
reviewed
Apr 1, 2024
src/test/csrc/common/vga.cpp
Outdated
| @@ -60,6 +60,12 @@ void init_sdl() { | |||
| SDL_SetWindowTitle(window, "NOOP"); | |||
| texture = SDL_CreateTexture(renderer, SDL_PIXELFORMAT_ARGB8888, SDL_TEXTUREACCESS_STATIC, SCREEN_W, SCREEN_H); | |||
| } | |||
|
|
|||
| void finish_sdl() { | |||
| for (size_t i = 0; i < SCREEN_H; i++) { | |||
There was a problem hiding this comment.
Why for loop here? Seems SCREEN_W * SCREEN_H is OK
|
type_t array[xx]; |
xiaokamikami
force-pushed
the
finish_device
branch
from
e1bdf78 to
5ccb8d1
Compare
klin02
reviewed
Apr 2, 2024
src/test/csrc/common/uart.cpp
Outdated
| @@ -106,3 +106,9 @@ static void preset_input() { | |||
| void init_uart(void) { | |||
| preset_input(); | |||
| } | |||
|
|
|||
| void finish_uart(void) { | |||
| memset((void *)&queue, 0, QUEUE_SIZE * sizeof(char)); | |||
klin02
reviewed
Apr 2, 2024
src/test/csrc/common/vga.cpp
Outdated
| @@ -60,6 +60,10 @@ void init_sdl() { | |||
| SDL_SetWindowTitle(window, "NOOP"); | |||
| texture = SDL_CreateTexture(renderer, SDL_PIXELFORMAT_ARGB8888, SDL_TEXTUREACCESS_STATIC, SCREEN_W, SCREEN_H); | |||
| } | |||
|
|
|||
| void finish_sdl() { | |||
| memset(vmem, 0, SCREEN_H * SCREEN_W * sizeof(vmem)); | |||
There was a problem hiding this comment.
sizeof(vmem) equals H*W*size(uint32_t)
Simply sizeof(vmem) is OK
klin02
approved these changes
Apr 2, 2024
klin02
changed the title
klin02
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to release peripherals upon reset