difftest: move declaration of extern func to header #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous we declare and implement extern func in cpp file directly, and call by import DPIC in verilog or another extern declaration in other cpp files. However, when supporting gsim, too many extern declaration and calls in different files make it hard to link and locate, causing undefined reference error. This change move declaration of extern func to header, add we will include header while generating extern-module func.
poemonsense
approved these changes
Nov 25, 2024
Tang-Haojin
pushed a commit
that referenced
this pull request
Nov 25, 2024
Previous we declare and implement extern func in cpp file directly, and call by import DPIC in verilog or another extern declaration in other cpp files. However, when supporting gsim, too many extern declaration and calls in different files make it hard to link and locate, causing undefined reference error. This change move declaration of extern func to header, add we will include header while generating extern-module func.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous we declare and implement extern func in cpp file directly, and call by import DPIC in verilog or another extern declaration in other cpp files.
However, when supporting gsim, too many extern declaration and calls in different files make it hard to link and locate, causing undefined reference error.
This change move declaration of extern func to header, add we will include header while generating extern-module func.