fix(dbltrp): critical-error is not treated as diff error #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lewislzh
commented
Nov 4, 2024
lewislzh
commented
- When both RTL and NEMU report a critical-error, the hardware behavior is considered correct. Upon detecting a critical-error, it should indicate a "good trap."
- If they do not report simultaneously, it results in a diff error and triggers an abort.
lewislzh
force-pushed
the
fix-critical-error
branch
from
624c587 to
61fb531
Compare
poemonsense
reviewed
Nov 5, 2024
lewislzh
force-pushed
the
fix-critical-error
branch
from
61fb531 to
9808eaf
Compare
poemonsense
reviewed
Nov 5, 2024
src/test/csrc/difftest/difftest.cpp
Outdated
| Info("Core %d dump: critical_error raise \n", this->id); | ||
| raise_trap(STATE_ABORT); | ||
| bool ref_critical_error = proxy->raise_critical_error(); | ||
| if (dut->critical_error.valid && dut->critical_error.criticalError) { |
There was a problem hiding this comment.
Should it be like:
if (dut->critical_error.valid && dut->critical_error.criticalError) {
bool ref_critical_error = proxy->raise_critical_error();
if (ref_critical_error) ...
...
}Only when DUT raises the critical error, we check whether REF raises it?
lewislzh
force-pushed
the
fix-critical-error
branch
from
9808eaf to
705bdee
Compare
* When both RTL and NEMU report a critical-error, the hardware behavior is considered correct. Upon detecting a critical-error, it should indicate a "good trap." * If they do not report simultaneously, it results in a diff error and triggers an abort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.