Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aia): add support for aia xtopei csr #510

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

sinceforYy
Copy link
Contributor

@sinceforYy sinceforYy commented Nov 21, 2024

In order for NEMU to use the value of the xtopi register for interrupt handling, we need to update the xtopi register in NEMU. Since NEMU does not support the out-of-core part of AIA, we need to use the value of xtopei when updating xtopi, so we pass xtopei through the difftest framework.

Copy link
Member

@poemonsense poemonsense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me except the warning message when aia is not supported in the REF

inline void aia_xtopei(struct AIAXtopei &xtopei) {
if (ref_aia_xtopei) {
ref_aia_xtopei(&xtopei);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we print something here to tell the user the API has not been implemented in the REF?

@poemonsense poemonsense merged commit 7d3d2fb into OpenXiangShan:master Nov 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants