Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support perfcct #521

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support perfcct #521

wants to merge 1 commit into from

Conversation

tastynoob
Copy link
Contributor

No description provided.

@tastynoob tastynoob requested a review from poemonsense December 9, 2024 09:07
Copy link
Member

@poemonsense poemonsense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please format the commit title, commit message, and code

  2. Will ChiselDB always generate perfCCT.cpp? If not, please use another macro specifically for perfCCT.cpp.

  3. The main.cpp currently only applies to Verilator. Should we support perfCCT.cpp in VCS?

@tastynoob
Copy link
Contributor Author

  1. Please format the commit title, commit message, and code
  2. Will ChiselDB always generate perfCCT.cpp? If not, please use another macro specifically for perfCCT.cpp.
  3. The main.cpp currently only applies to Verilator. Should we support perfCCT.cpp in VCS?

2: yes, perfCCT reuse chiselDB init function
3: yes, need some time

@tastynoob
Copy link
Contributor Author

remove global_sim_tick from main.cpp, use verilog dpic function update tick per cycle

Copy link
Member

@poemonsense poemonsense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I still doubt the necessity of introducing perfCCT.cpp in ChiselDB, which is expected to create only chisel_db.cpp, the approval of this PR will depend on the approval and merging of OpenXiangShan/Utility#88. Please first consult the maintainers of ChiselDB before changing the ChiselDB C++ APIs in difftest. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants