remove constant

Opentrons · Jan 15, 2025 · 06f2fdb · 06f2fdb
1 parent 5ea4660
commit 06f2fdb
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 89 deletions.
diff --git a/components/src/atoms/MenuList/MenuItem.stories.tsx b/components/src/atoms/MenuList/MenuItem.stories.tsx
@@ -1,5 +1,5 @@
+import { STYLE_PROPS } from '../../primitives'
 import { VIEWPORT } from '../../ui-style-constants'
-import { allDefaultStorybookControlsWithStyleProps } from '../../constants'
 import { MenuItem as MenuItemComponent } from './MenuItem'
 import type { Meta, StoryObj } from '@storybook/react'
 
@@ -10,7 +10,7 @@ const meta: Meta<typeof MenuItemComponent> = {
   argTypes: {
     // Disable all StyleProps
     ...Object.fromEntries(
-      allDefaultStorybookControlsWithStyleProps.map(prop => [
+      [...STYLE_PROPS, 'as', 'ref', 'theme', 'forwardedAs'].map(prop => [
         prop,
         { table: { disable: true } },
       ])

diff --git a/components/src/atoms/MenuList/MenuList.stories.tsx b/components/src/atoms/MenuList/MenuList.stories.tsx
@@ -1,5 +1,4 @@
-import { action } from '@storybook/addon-actions'
-import { Flex } from '../../primitives'
+import { Flex, STYLE_PROPS } from '../../primitives'
 import { DIRECTION_COLUMN } from '../../styles'
 import { MenuList as MenuListComponent } from './index'
 import { MenuItem } from './MenuItem'
@@ -11,8 +10,18 @@ const menuBtn = 'Example menu btn'
 const meta: Meta<typeof MenuListComponent> = {
   title: 'Helix/Atoms/MenuList',
   component: MenuListComponent,
-  args: {
-    onClick: action('clicked'),
+  argTypes: {
+    // Disable all StyleProps
+    ...Object.fromEntries(
+      [
+        ...STYLE_PROPS,
+        'as',
+        'ref',
+        'theme',
+        'forwardedAs',
+        'className',
+      ].map(prop => [prop, { table: { disable: true } }])
+    ),
   },
 }
 

diff --git a/components/src/constants.ts b/components/src/constants.ts
diff --git a/components/src/index.ts b/components/src/index.ts
@@ -39,5 +39,3 @@ export * from './molecules'
 
 // Atoms
 export * from './atoms'
-
-export * from './constants'
diff --git a/components/src/primitives/style-props.ts b/components/src/primitives/style-props.ts
@@ -106,7 +106,7 @@ const POSITION_PROPS = [
 
 const TRANSITION_PROPS = ['transition'] as const
 
-const STYLE_PROPS = [
+export const STYLE_PROPS = [
   ...COLOR_PROPS,
   ...TYPOGRAPHY_PROPS,
   ...SPACING_PROPS,
Original file line number	Diff line number	Diff line change
Expand Up		@@ -39,5 +39,3 @@ export * from './molecules'

		// Atoms
		export * from './atoms'

		export * from './constants'