-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patches: Various additions and improvements #221
Conversation
|
||
|
||
author=El_Patas | ||
comment=Widescreen Hack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did the patch go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's one of those situations where the main ELF isn't the one to apply the patch to, but it's required for the game to show the patches and be able to activate them. It is better explained here: PCSX2/pcsx2#9243 (comment)
More specific:
I see the point about it being an edge case with a loader ELF - in this case, I'd suggest duplicating the pnach file for both CRCs, but leaving the codes empty for the loader.
We will not be restoring the old behaviour. It was broken from the beginning, and caused crashes/broken games when patches were applying to the wrong ELF.
I've tested it and this way it shows the patches on the game settings and applies the chosen patches on the right ELFs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh one of those... well that's kind of annoying. Alright, maybe put a comment in the patch file mentioning the filename of the one it's enabling, and why that one is there, same for the other one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
||
|
||
author=ElHecht | ||
comment=Widescreen Hack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did the patch go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the other one.
Thanks :) |
Changes:
All of the patches have been tested for all versions of the games, and relevant comments such as activating widescreen in-game or the need for EE Overclock have been added.