Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the version #898

Merged
merged 12 commits into from
Feb 7, 2024
Merged

Updated the version #898

merged 12 commits into from
Feb 7, 2024

Conversation

rickecon
Copy link
Member

@rickecon rickecon commented Feb 6, 2024

This PR:

  • Updates the version in setup.py and ogcore/__init__.py
  • Update the copyright year of documentation to 2024
  • Adds a CHANGELOG.md file
  • Swapped the LICENSE.md for the official CC0-1.0 LICENSE file. This way, the license type shows up on our main page right-hand-side license
  • Upgraded and organized the smart tags at the beginning of the README.md and added them to the beginning of the intro.md page of the documentation

cc: @jdebacker

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (42cd461) 80.52% compared to head (1c9f284) 80.52%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #898   +/-   ##
=======================================
  Coverage   80.52%   80.52%           
=======================================
  Files          19       19           
  Lines        4452     4452           
=======================================
  Hits         3585     3585           
  Misses        867      867           
Flag Coverage Δ
unittests 80.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ogcore/__init__.py 100.00% <100.00%> (ø)

@rickecon
Copy link
Member Author

rickecon commented Feb 7, 2024

@jdebacker. This PR is ready to go.

@rickecon
Copy link
Member Author

rickecon commented Feb 7, 2024

@jdebacker. My ogcore-dev conda environment originally had the black package version 23.?.?. I noticed that when I ran it, it had me update two files to which I made no changes: firm.py and txfunc.py. These formatting changes caused those two files to fail the GH Action "Check Black formatting". I noticed in the GH Action log for the "Check Black formatting" tests that it was loading black version 24.1.1.

I deleted my ogcore-dev conda environment and reinstalled it, which produced an environment with the updated black version 24.1.1. Because the old black version 23.?.? gives results that are different from version 24.1.1, I recommend that we set the black version in environment.yml to be >=24.1.1. I have done this in my most recent commit.

@jdebacker
Copy link
Member

@rickecon Thanks for this PR. LGTM. Merging.

@jdebacker jdebacker merged commit 0866c09 into PSLmodels:master Feb 7, 2024
11 checks passed
@rickecon rickecon deleted the vers branch February 12, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants