-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uorb: add section on nested messages #3562
Merged
+90
−25
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
57f6674
uorb: add section on nested messages
GuillaumeLaine 73287d5
Major restructure intro
hamishwillee 7663cd7
Apply suggestions from code review
hamishwillee 4ef1985
More corrections following review. Add links to Junwoo tutorial
hamishwillee 6b59e36
apply review suggestion
GuillaumeLaine df6c615
listener command
hamishwillee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GuillaumeLaine A few lines below it says
Is that still true? How can I check the supported boards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, I'm not even sure how to check. I think the CONFIG_SYSTEMCMDS_TOPIC_LISTENER=y board config enables the
listener
command, but I'm not sure.If this is case, this config does seem enabled for most boards.
What I can tell is that the line you quoted was written in the docs earlier (4 years ago) than the listener board config was enabled in most boards (3 years ago). Seems possible that docs were not updated after the fact
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice forensics! Also interesting that the boards after fmuv4 are enabled, but the older ones aren't. I'm going to update this as though we were certain.