-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nice data access API #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasDebrunner
changed the title
[WIP] Add nice data access API
Add nice data access API
Oct 4, 2023
bkueng
reviewed
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! I like the type magic.
Would be good to have some unit tests for the nested data access case.
Thank you for the review! I'll work on adding more unit tests. |
Also merged in main |
This changes the library the following way: - The field class now also stores sizes and offsets in the message format - The value class is overhauled to automatically cast to the right types based on the message definitions - The value class can automatically cast to the users desired types - The MessageFormat contains all information needed to parse the message - The MessageFormats are resolved recursively once the header is received
allows derived classes to modify the data
ThomasDebrunner
force-pushed
the
read-api
branch
from
October 17, 2023 09:54
d66f60c
to
ef02b28
Compare
…g place, with wrong length
ThomasDebrunner
force-pushed
the
read-api
branch
from
October 18, 2023 14:52
a71c8ef
to
ace6b68
Compare
Also added a bunch of unit testing for the added functionality |
bkueng
reviewed
Oct 26, 2023
Co-authored-by: Beat Küng <[email protected]>
bkueng
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the library the following way:
Still to do:
Nested types are resolved correctly, but the API to access in a nested way is missingMake sure all the previous tests and use cases are still supportedCreate new tests for the added functionlityThis allows the user to read data like this: