【Hackathon 7th No.22】NO.22 在 paddle.audio.functional.get_window 中支持 bartlett 、 kaiser 和 nuttall 窗函数 -part #68268
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
请问这个是需要验证什么吗？那个cla是签署了的。 |
|
#68270 |
|
|
Micalling
force-pushed
the
window
branch
5 times, most recently
from
b0eb09f
to
5f0313c
Compare
|
|
Micalling
force-pushed
the
window
branch
4 times, most recently
from
a340537
to
5e45e1b
Compare
| "triang", | ||
| "bohman", | ||
| ], | ||
| [True, False], |
There was a problem hiding this comment.
另外也请review一下这个#68268 我觉得ci似乎有问题，我在 test/legacy_test/test_audio_functions.py 中的修改并没有执行，导致我一开始的单侧覆盖率一直过不去，后来我新加一个文件后，他却提示数据对不上，但我在本身的window电脑、aistudio的linux环境以及我朋友的mac电脑里面都是可以的，另外您也是可以看到，代码使用的都是paddle已经实现的api
我看这里的修改和原来的一样呀。
目前单侧没有过。
There was a problem hiding this comment.
There was a problem hiding this comment.
已经可以了，请review @jeff41404
…artlett 、 kaiser 和 nuttall 窗函数
|
Sorry to inform you that 761b5cf's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
| @@ -31,6 +31,8 @@ | |||
| 'hamming', | |||
| 'hann', | |||
| 'kaiser', | |||
| 'bartlett', | |||
| 'nuttall', | |||
There was a problem hiding this comment.
because of adding types of window functions, we should synchronously expand the introduction documents of window member in Spectrogram, MelSpectrogram, LogMelSpectrogram, and MFCC classes below in this file.
test/legacy_test/test_get_window.py
Outdated
|
|
||
|
|
||
| class TestAudioFuncitons(unittest.TestCase): | ||
| def test_bartlett_nuttall_kaiser_window(self): |
There was a problem hiding this comment.
it's better to add other 11 unit tests of window function besides these three?
|
I am add the tests to the files. Please review @jeff41404 |
luotao1
changed the title
|
hi, @Micalling
|
PR Category
Inference
PR Types
Others
Description
【Hackathon 7th No.22】NO.22 在 paddle.audio.functional.get_window 中支持 bartlett 、 kaiser 和 nuttall 窗函数