【Hackathon 7th No.23】NO.23 为 Paddle 新增 ParameterDict API -part #68270

Micalling · 2024-09-17T07:42:06Z

PR Category

Inference

PR Types

Others

Description

【Hackathon 7th No.23】NO.23 为 Paddle 新增 ParameterDict API
RFC：PaddlePaddle/community#959
Docs：PaddlePaddle/docs#6874

paddle-bot · 2024-09-17T07:42:11Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

CLAassistant · 2024-09-18T10:22:59Z

All committers have signed the CLA.

Micalling · 2024-09-20T03:36:00Z

请问这是怎么回事？我是按照ParameterList写的

Micalling · 2024-09-20T03:36:21Z

请问这是怎么回事？我是按照ParameterList写的

@luotao1

Micalling · 2024-09-20T12:56:02Z

这个好像是需要你这里同意？
@jeff41404

Micalling · 2024-09-21T01:49:23Z

还有这个似乎是在nn.__init__中添加了ParameterDict后需要确认
@luotao1 @jeff41404

jeff41404 · 2024-09-24T03:57:09Z

python/paddle/nn/layer/container.py

+            ...             tmp = self._helper.create_variable_for_type_inference('float32')
+            ...             self._helper.append_op(
+            ...                 type="mul",
+            ...                 inputs={"X": x,
+            ...                         "Y": p},
+            ...                 outputs={"Out": tmp},
+            ...                 attrs={"x_num_col_dims": 1,
+            ...                         "y_num_col_dims": 1})
+            ...             x = tmp


please use public APIs instead of non-public APIs(self._helper.create_variable_for_type_inference and self._helper.append_op) in the example code. for example, x = paddle.multiply(x, p) or x = x * p

jeff41404 · 2024-09-24T04:05:10Z

test/legacy_test/test_imperative_container_parameterdict.py

+
+    def forward(self, x):
+        for i, (key, _) in enumerate(self.params):
+            x = _legacy_C_ops.mul(x, self.params[key])


it better to use public API to increase maintainability, e.g. paddle.matmul ?

jeff41404 · 2024-09-24T04:10:08Z

还有这个似乎是在nn.__init__中添加了ParameterDict后需要确认 @luotao1 @jeff41404

Yes, adding a public API requires confirmation. You don't need to handle this CI temporarily. Once you solve other problems and approved, PR-CI-Static-Check will pass

jeff41404 · 2024-09-24T04:11:03Z

please add link of rfc and docs in description above.

Micalling · 2024-09-24T08:04:02Z

please add link of rfc and docs in description above.

已经将相应的链接加上去了，需要修改的也已经修改完毕。劳烦再review一下。另外也请review一下这个#68268 我觉得ci似乎有问题，我在 test/legacy_test/test_audio_functions.py 中的修改并没有执行，导致我一开始的单侧覆盖率一直过不去，后来我新加一个文件后，他却提示数据对不上，但我在本身的window电脑、aistudio的linux环境以及我朋友的mac电脑里面都是可以的，另外您也是可以看到，代码使用的都是paddle已经实现的api

zhangting2020

LGTM for PR-CI-Distribute-stable

jeff41404

LGTM

Micalling · 2024-09-28T04:23:07Z

你好，请问这个PI-CI-Static-Check需要怎么解决的？ @sunzhongkai588

paddle-ci-bot · 2024-10-03T03:15:03Z

Sorry to inform you that 915b5b9's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

monster1015 · 2024-10-06T01:56:54Z

请问这是怎么回事？ @luotao1

Micalling · 2024-10-09T05:55:37Z

你好，请问能否review一下？ @sunzhongkai588

Micalling · 2024-10-09T08:18:24Z

请问这个是不是三个人都review的， @luotao1
http://preview-paddle-pr-68270.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/en/develop/api/paddle/nn/ParameterDict_en.html
然后这个文档构建好像也好了

sunzhongkai588

LGTM @SigureMo review一下type annotation

SigureMo · 2024-10-09T12:10:51Z

python/paddle/nn/layer/container.py

+        self,
+        parameters: (
+            ParameterDict
+            | typing.Mapping[str, Tensor]


为什么要用 typing.Mapping 而不是已经 import 了的 collections.abc.Mapping？

SigureMo · 2024-10-09T12:15:36Z

python/paddle/nn/layer/container.py

+    def __len__(self) -> int:
+        return len(self._parameters)
+
+    def __iter__(self) -> Iterator[tuple[str, Tensor]]:


为什么这个 __iter__ 返回结果的语义与 Python 的 dict 不一样，不是 dict 的 key 的 iterator，而是 key-value pair 的 iterator？这里的设计是基于什么？

抱歉，这里是多加了的，参考layerdict然后看岔了

SigureMo · 2024-10-09T12:18:16Z

python/paddle/nn/layer/container.py

+        self,
+        parameters: (
+            ParameterDict
+            | typing.Mapping[str, Tensor]


SigureMo · 2024-10-09T12:26:01Z

python/paddle/nn/layer/container.py

+            ...         super().__init__()
+            ...         # create ParameterDict with iterable Parameters
+            ...         self.params = paddle.nn.ParameterDict(
+            ...             {'t' + str(i): paddle.create_parameter(shape=[2, 2], dtype='float32') for i in range(num_stacked_param)})


Suggested change

... {'t' + str(i): paddle.create_parameter(shape=[2, 2], dtype='float32') for i in range(num_stacked_param)})

... {f"t{i}": paddle.create_parameter(shape=[2, 2], dtype='float32') for i in range(num_stacked_param)})

SigureMo · 2024-10-09T12:27:53Z

python/paddle/nn/layer/container.py

+                    raise ValueError(
+                        "The length of the "
+                        + str(i)
+                        + "'s element in parameters is "
+                        + str(len(kv))
+                        + ", which must be 2."
+                    )


用 f-string

SigureMo · 2024-10-10T02:19:53Z

python/paddle/nn/layer/container.py

+    def __len__(self) -> int:
+        return len(self._parameters)
+
+    def __iter__(self) -> Iterator[tuple[str, Tensor]]:


Suggested change

def __iter__(self) -> Iterator[tuple[str, Tensor]]:

def __iter__(self) -> Iterator[str]:

类型提示没改

param_guard 不需要，因为返回的 iterator 访问不到参数

好的好的，已经修改了

Micalling · 2024-10-10T13:40:06Z

请问这是怎么回事？ @sunzhongkai588

SigureMo · 2024-10-10T16:06:48Z

CI 出了点问题，遇到类似问题可以考虑直接用一个空的 commit 重新触发 CI，或者 convert to draft + ready to review 来重新触发 CI

帮你用了另一种方式重新触发了全部 CI（lock + unlock，你没权限，但前两种你是有权限的）

SigureMo

LGTMeow for new API type annotations and print usage

Micalling mentioned this pull request Sep 17, 2024

【Hackathon 7th No.22】NO.22 在 paddle.audio.functional.get_window 中支持 bartlett 、 kaiser 和 nuttall 窗函数 -part #68268

Merged

paddle-bot bot added the contributor External developers label Sep 17, 2024

luotao1 mentioned this pull request Sep 18, 2024

【Hackathon 7th】开源贡献个人挑战赛 #68244

Open

luotao1 added the PaddlePaddle Hackathon label Sep 18, 2024

luotao1 assigned luotao1 and jeff41404 Sep 18, 2024

Micalling force-pushed the Dict branch from 12356b8 to da89a71 Compare September 20, 2024 04:41

【Hackathon 7th No.23】NO.23 为 Paddle 新增 ParameterDict API

13f3991

Micalling force-pushed the Dict branch from 79bc735 to 13f3991 Compare September 20, 2024 11:58

jeff41404 reviewed Sep 24, 2024

View reviewed changes

update

588f4e9

zhangting2020 previously approved these changes Sep 24, 2024

View reviewed changes

jeff41404 previously approved these changes Sep 25, 2024

View reviewed changes

update

915b5b9

Micalling dismissed stale reviews from jeff41404 and zhangting2020 via 915b5b9 September 25, 2024 05:45

luotao1 assigned sunzhongkai588 Sep 25, 2024

Merge branch 'PaddlePaddle:develop' into Dict

12e0d38

sunzhongkai588 previously approved these changes Oct 9, 2024

View reviewed changes

SigureMo reviewed Oct 9, 2024

View reviewed changes

update

6d98f48

Micalling dismissed sunzhongkai588’s stale review via 6d98f48 October 10, 2024 01:39

SigureMo reviewed Oct 10, 2024

View reviewed changes

Micalling added 5 commits October 10, 2024 12:06

update

7724466

update

0fb700e

update

21a3ab9

update

88330a4

update

da3880c

PaddlePaddle locked and limited conversation to collaborators Oct 10, 2024

PaddlePaddle unlocked this conversation Oct 10, 2024

SigureMo approved these changes Oct 10, 2024

View reviewed changes

luotao1 changed the title ~~【Hackathon 7th No.23】NO.23 为 Paddle 新增 ParameterDict API~~ 【Hackathon 7th No.23】NO.23 为 Paddle 新增 ParameterDict API -part Oct 11, 2024

luotao1 merged commit e898b19 into PaddlePaddle:develop Oct 11, 2024
26 of 27 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

【Hackathon 7th No.23】NO.23 为 Paddle 新增 ParameterDict API -part #68270

【Hackathon 7th No.23】NO.23 为 Paddle 新增 ParameterDict API -part #68270

Micalling commented Sep 17, 2024 •

edited

Loading

paddle-bot bot commented Sep 17, 2024

CLAassistant commented Sep 18, 2024 •

edited

Loading

Micalling commented Sep 20, 2024

Micalling commented Sep 20, 2024

Micalling commented Sep 20, 2024

Micalling commented Sep 21, 2024 •

edited

Loading

jeff41404 Sep 24, 2024

jeff41404 Sep 24, 2024

jeff41404 commented Sep 24, 2024

jeff41404 commented Sep 24, 2024

Micalling commented Sep 24, 2024 •

edited

Loading

zhangting2020 left a comment

jeff41404 left a comment

Micalling commented Sep 28, 2024

paddle-ci-bot bot commented Oct 3, 2024

monster1015 commented Oct 6, 2024

Micalling commented Oct 9, 2024 •

edited

Loading

Micalling commented Oct 9, 2024

sunzhongkai588 left a comment

SigureMo Oct 9, 2024

SigureMo Oct 9, 2024

Micalling Oct 10, 2024

SigureMo Oct 9, 2024

SigureMo Oct 9, 2024

SigureMo Oct 9, 2024

SigureMo Oct 10, 2024

Micalling Oct 10, 2024

Micalling commented Oct 10, 2024

SigureMo commented Oct 10, 2024

SigureMo left a comment

	... {'t' + str(i): paddle.create_parameter(shape=[2, 2], dtype='float32') for i in range(num_stacked_param)})
	... {f"t{i}": paddle.create_parameter(shape=[2, 2], dtype='float32') for i in range(num_stacked_param)})

	def __iter__(self) -> Iterator[tuple[str, Tensor]]:
	def __iter__(self) -> Iterator[str]:

【Hackathon 7th No.23】NO.23 为 Paddle 新增 ParameterDict API -part #68270

【Hackathon 7th No.23】NO.23 为 Paddle 新增 ParameterDict API -part #68270

Conversation

Micalling commented Sep 17, 2024 • edited Loading

PR Category

PR Types

Description

paddle-bot bot commented Sep 17, 2024

CLAassistant commented Sep 18, 2024 • edited Loading

Micalling commented Sep 20, 2024

Micalling commented Sep 20, 2024

Micalling commented Sep 20, 2024

Micalling commented Sep 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeff41404 commented Sep 24, 2024

jeff41404 commented Sep 24, 2024

Micalling commented Sep 24, 2024 • edited Loading

zhangting2020 left a comment

Choose a reason for hiding this comment

jeff41404 left a comment

Choose a reason for hiding this comment

Micalling commented Sep 28, 2024

paddle-ci-bot bot commented Oct 3, 2024

monster1015 commented Oct 6, 2024

Micalling commented Oct 9, 2024 • edited Loading

Micalling commented Oct 9, 2024

sunzhongkai588 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Micalling commented Oct 10, 2024

SigureMo commented Oct 10, 2024

SigureMo left a comment

Choose a reason for hiding this comment

Micalling commented Sep 17, 2024 •

edited

Loading

CLAassistant commented Sep 18, 2024 •

edited

Loading

Micalling commented Sep 21, 2024 •

edited

Loading

Micalling commented Sep 24, 2024 •

edited

Loading

Micalling commented Oct 9, 2024 •

edited

Loading