Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seq table2cmd #52

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Conversation

evalott100
Copy link
Contributor

@evalott100 evalott100 commented Jun 13, 2023

Closes #49

Adds the functionality missing in #50, making the conversion more general.

- convert one seq talbe line into a command to send
@evalott100 evalott100 self-assigned this Jun 13, 2023
@evalott100 evalott100 force-pushed the add-seq_table2cmd branch 2 times, most recently from 77eaad3 to 9a2ec77 Compare June 13, 2023 08:47
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14 🎉

Comparison is base (8729a25) 96.20% compared to head (6a06054) 96.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   96.20%   96.35%   +0.14%     
==========================================
  Files          11       12       +1     
  Lines        1108     1151      +43     
==========================================
+ Hits         1066     1109      +43     
  Misses         42       42              
Impacted Files Coverage Δ
pandablocks/utils.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@coretl coretl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just a couple of changes need changing in the code originally in the IOC repo

pandablocks/utils.py Outdated Show resolved Hide resolved
pandablocks/utils.py Outdated Show resolved Hide resolved
pandablocks/utils.py Outdated Show resolved Hide resolved
pandablocks/utils.py Outdated Show resolved Hide resolved
pandablocks/utils.py Outdated Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
@coretl
Copy link
Contributor

coretl commented Jun 13, 2023

Also, please could you add some entries in the docs for this?

@evalott100 evalott100 force-pushed the add-seq_table2cmd branch 2 times, most recently from 53d2eae to 7a70090 Compare June 14, 2023 13:45
Copy link
Contributor

@AlexanderWells-diamond AlexanderWells-diamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine except a couple of minor points.

I would like to see more tests written, for anything that isn't the expected case. I had tests for these cases in the PandAblocks-ioc repo so it seems a shame to lose them.

pandablocks/utils.py Outdated Show resolved Hide resolved
pandablocks/utils.py Outdated Show resolved Hide resolved
@AlexanderWells-diamond
Copy link
Contributor

Another thought: Is it worth trying to use this in PandABlocks-ioc before merging this? That'll check if the API actually is compatible with that project.

pandablocks/utils.py Outdated Show resolved Hide resolved
@evalott100
Copy link
Contributor Author

Another thought: Is it worth trying to use this in PandABlocks-ioc before merging this? That'll check if the API actually is compatible with that project.

I've now adjusted pandablocks-ioc to use the functions here: PandABlocks/PandABlocks-ioc#15. Everything is passing apart from one test which is broken on dev anyway.

@coretl coretl merged commit d9516e5 into PandABlocks:master Jul 19, 2023
6 checks passed
@evalott100 evalott100 deleted the add-seq_table2cmd branch July 20, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add helper function converts Sequencer Table Line into an integer
3 participants