Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altered code to use the new utils functions #15

Merged

Conversation

evalott100
Copy link
Contributor

@evalott100 evalott100 commented Jun 28, 2023

Closes #16

Should only be merged after PandABlocks/PandABlocks-client#52

@evalott100 evalott100 force-pushed the adjust_to_use_table_packing_in_utils branch from 593f747 to bc7ee71 Compare June 29, 2023 09:02
@evalott100 evalott100 linked an issue Jun 29, 2023 that may be closed by this pull request
@evalott100
Copy link
Contributor Author

Tests failing because pandablocks_client requires release with this PR

Copy link
Contributor

@AlexanderWells-diamond AlexanderWells-diamond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with these changes, but I think it would be best to wait for a PandA-client release and update our dependencies before merging this.

@evalott100 evalott100 mentioned this pull request Sep 1, 2023
@evalott100 evalott100 changed the base branch from dev to main September 5, 2023 08:36
@evalott100 evalott100 force-pushed the adjust_to_use_table_packing_in_utils branch from bc7ee71 to 14d6e3a Compare September 11, 2023 10:01
@evalott100 evalott100 force-pushed the adjust_to_use_table_packing_in_utils branch from 14d6e3a to ea45440 Compare September 11, 2023 10:20
@evalott100 evalott100 merged commit 35360f4 into PandABlocks:main Sep 13, 2023
8 checks passed
@evalott100 evalott100 deleted the adjust_to_use_table_packing_in_utils branch September 13, 2023 09:35
@evalott100 evalott100 mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust to using Pandablocks-client for pack and unpack
2 participants