Notifications cleanup #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobJaffe
approved these changes
Jul 17, 2020
| @@ -120,6 +124,7 @@ public static void registerSyncChannel(Context context) { | |||
| public static NotificationChannel createServiceChannel(CharSequence name) { | |||
| NotificationChannel channel = new NotificationChannel(SERVICE_CHANNEL_ID, name, android.app.NotificationManager.IMPORTANCE_LOW); | |||
| channel.enableVibration(false); | |||
| channel.setShowBadge(false); // avoid badge count due to background service notification | |||
|
Added a new commit to remove the permissions channel since it's not being used. |
|
How to test: 1- Clone locally https://github.com/Path-Check/react-native-background-geolocation 3- Change this line in https://github.com/Path-Check/covid-safe-paths/blob/develop/package.json to use the local dependency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the solution proposed in this issue Path-Check/safeplaces-dct-app#1276
covid-safe-pathsproject, however, we also added the fallback names in this package just in case. These names are generic and not project specific.