-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates of fates model #3233
Updates of fates model #3233
Conversation
@Hhh-hyc Yucong congratulations on your first PEcAn PR, thank you for contributing. Let's iterate with the suggested revisions. |
@Hhh-hyc wanted to ping you about finishing up this PR, which has been in the queue for a while |
|
@Hhh-hyc checking in again on this PR which seems to require fairly minor changes to pass the GH Action checks. Is this something you'll be able to get back to soon? |
a3ab775
to
2920203
Compare
models/fates/DESCRIPTION
Outdated
@@ -21,8 +21,7 @@ Imports: | |||
PEcAn.logger, | |||
PEcAn.remote, | |||
PEcAn.utils, | |||
lubridate (>= 1.6.0), | |||
ncdf4 (>= 1.15) | |||
lubridate (>= 1.6.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ncdf4
still needs to be here as your package functions use this library
Description
Changes made in this pull request:
Motivation and Context
Integrate the newest version of CTSM-FATES into PEcAn. CTSM-FATES is assumed to be run in a docker or openshift container. The work is relevant to the issue on PEcAN #1008 and the issue on FATES: NGEET/fates#364
Review Time Estimate
Types of changes
Checklist: