Deprecate inner_transform_program and config arguments to qml.execute
#6822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6822 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 476 476
Lines 45190 45194 +4
=======================================
+ Hits 45011 45015 +4
Misses 179 179 ☔ View full report in Codecov by Sentry. |
andrijapau
commented
Jan 15, 2025
andrijapau
commented
Jan 15, 2025
andrijapau
commented
Jan 15, 2025
andrijapau
commented
Jan 15, 2025
andrijapau
commented
Jan 15, 2025
andrijapau
commented
Jan 15, 2025
andrijapau
commented
Jan 15, 2025
andrijapau
commented
Jan 15, 2025
astralcai
reviewed
Jan 15, 2025
andrijapau
commented
Jan 15, 2025
astralcai
approved these changes
Jan 16, 2025
Co-authored-by: Astral Cai <[email protected]>
lillian542
reviewed
Jan 16, 2025
andrijapau
added a commit
that referenced
this pull request
Jan 24, 2025
**Context:** PR #6822 deprecated the arguments `config` and `inner_transform_program` to `qml.execute`. However, because of some bug in our CI, the `qml.PennyLaneDeprecationWarning` are not being treated as errors. I just happened to find this warning in our CI logs. **Description of the Change:** Promoted `qml.PennyLaneDeprecationWarning` to a `ValueError` to fish out any deprecated code. Updated said code to use `qml.workflow.run` instead of `qml.execute`. [sc-81529]
andrijapau
added a commit
that referenced
this pull request
Jan 28, 2025
**Context:** Removes unnecessary `replace` that survived after some updates made in #6822. This code just redundantly sets the `interface` and `derivative_order` right after it is set a bit earlier. **Benefits:** Neater code. **Possible Drawbacks:** None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
If users want this level of detail for execution they can use
qml.workflow.run. This is done so we can have better signature parity withQNode.Also, shuffled around the kwargs of
qml.executeto matchQNodebetter. Also added better typing.[sc-81529]