Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades to Petrosian and Petrosian Corrections [v0.5.0 Core] #169

Merged
merged 25 commits into from
Aug 20, 2023

Conversation

robelgeda
Copy link
Contributor

@robelgeda robelgeda commented Dec 31, 2022

closes #179, closes #44, closes #109, closes #162, closes #160, closes #123, closes #58, closes #112
Major upgrades to Petrosian workflow. It generalizes the Petrsoian profiles to use any eta and epsilon values.

This PR introduces:

  • A new option to address low signal-to-noise ratio issues when measuring r_99 by allowing the use of r_80. While r_80 provides good estimates of r_50 (r_e), it can sometimes result in an overestimation of r_99. To ensure accuracy, correction grids can be utilized to estimate r_99 from r_80. However, we maintain the Petrosian measurement philosophy that correction grids should be reserved for high-precision measurements. Therefore more analytical and testing work is needed before this PR can be merged into production.
  • Error estimates for all Petrosian Radii according to Strauss et. al 2002 Appendix A.3.
  • Saving/reading profiles to/from file.
  • Grid generation now has multi-processing support.

More work is needed to:

  • Make correction to 1D radial profiles. This may be out of the scope of this PR.

Other Changes

  • Remove kernel key word from segmentation functions since PhotUtils no longer accepts them.
  • order_cat moved to segmentation sub-module.
  • source_photometry moved to segmentation sub-module.
  • make_radius_list moved to utils sub-module.
  • Refactor: photometry.flux_to_abmag -> utils.hst_flux_to_abmag
  • Refactor: Move measure_fwhm from utils to modeling.fitting
  • Depreciate calculate_photometic_density
  • Depreciate object_photometry, now its called radial_photometry
  • Depreciate measure_fwhm

TODO:

  • Improve plots.

Cleanup checks:

  • Re-enable doc tests
  • Deal with ValueError: A value in x_new is above the interpolation range.

@robelgeda robelgeda changed the title Upgrades to Petrosian and Petrosian Corrections Upgrades to Petrosian and Petrosian Corrections [v0.5.0 Core] Aug 16, 2023
@robelgeda robelgeda added this to the v0.5.0 milestone Aug 16, 2023
@robelgeda robelgeda force-pushed the petrogen branch 4 times, most recently from dcf9f3c to 7399d0c Compare August 16, 2023 22:12
@robelgeda robelgeda removed the WIP Work in Progress label Aug 18, 2023
@robelgeda robelgeda merged commit b1f3888 into PetroFit:main Aug 20, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment