-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades to Petrosian and Petrosian Corrections [v0.5.0 Core] #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robelgeda
changed the title
Upgrades to Petrosian and Petrosian Corrections
Upgrades to Petrosian and Petrosian Corrections [v0.5.0 Core]
Aug 16, 2023
robelgeda
force-pushed
the
petrogen
branch
4 times, most recently
from
August 16, 2023 22:12
dcf9f3c
to
7399d0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #179, closes #44, closes #109, closes #162, closes #160, closes #123, closes #58, closes #112
Major upgrades to Petrosian workflow. It generalizes the Petrsoian profiles to use any
eta
andepsilon
values.This PR introduces:
r_99
by allowing the use ofr_80
. Whiler_80
provides good estimates ofr_50
(r_e
), it can sometimes result in an overestimation ofr_99
. To ensure accuracy, correction grids can be utilized to estimater_99
fromr_80
. However, we maintain the Petrosian measurement philosophy that correction grids should be reserved for high-precision measurements. Therefore more analytical and testing work is needed before this PR can be merged into production.More work is needed to:
Other Changes
kernel
key word from segmentation functions since PhotUtils no longer accepts them.order_cat
moved to segmentation sub-module.source_photometry
moved to segmentation sub-module.make_radius_list
moved to utils sub-module.photometry.flux_to_abmag
->utils.hst_flux_to_abmag
measure_fwhm
fromutils
tomodeling.fitting
calculate_photometic_density
object_photometry
, now its calledradial_photometry
measure_fwhm
TODO:
Cleanup checks:
ValueError: A value in x_new is above the interpolation range.