Update tahoma and mfc42 verb: use fileExists #1116

ImperatorS79 · 2019-09-06T12:24:30Z

Description

Fix a part of #1107 relating mfc42.

Ready for review

Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
json-align and eslint run according to the documentation.
Codacy and travis checked.

Merge Phoenicis/Scripts:master into ImperatorS79/Scripts:master

updated Hearthstone (download application directly) (PhoenicisOrg#383)

Merge master

Merge recent commits

Merge master

Merge Master

Merge master

ImperatorS79 · 2019-09-06T14:29:43Z

@Zemogiter could you test if this fixes your errors with mfc42 and tahoma ?

madoar · 2019-09-07T08:16:47Z

@ImperatorS79 I would like to wait until #1112 has been merged before we merge this

Zemogiter · 2019-09-07T09:41:26Z

@ImperatorS79 mfc42 works but in Tahoma we need extra ) in

scripts/Engines/Wine/Verbs/Tahoma/script.js

Line 27 in d3ab4e2

if(!fileExists(this.fontDirectory()) {

ImperatorS79 · 2019-09-10T18:41:16Z

@Zemogiter can you test again ?

madoar · 2019-09-10T18:42:25Z

Engines/Wine/Verbs/Tahoma/script.js

@@ -19,6 +19,10 @@ class Tahoma {
        const wizard = this.wine.wizard();
        const prefixDirectory = this.wine.prefixDirectory();
        const fontDirectory = this.wine.fontDirectory();
+
+        if (!fileExists(fontDirectory)) {


The method name sounds strange in this case. Should we add a dedicated method for folders? What do you think @plata @ImperatorS79?

We can do that. Would basically be an alias then, right?

Actually I'm not sure. If we decide to split the functionality into a fileExists and directoryExists method we could also test whether the given path is not a file/directory but instead a directory/file, depending on the regarded method.

Sounds reasonable.

plata · 2019-09-11T15:35:30Z

Please fix the PR title before merging.

Zemogiter · 2019-09-14T07:26:57Z

@ImperatorS79 at the begining of .cab file extraction I get the error saying the fonts directory does not exist but it does

Extracting to: /home/jonasz/.Phoenicis/containers//wineprefix//RimWorld//drive_c/tahoma/
/home/jonasz/.Phoenicis/resources///IELPKTH.CAB: WARNING; possible 5592 extra bytes at end of file.
Extracting cabinet: /home/jonasz/.Phoenicis/resources///IELPKTH.CAB

All done, no errors.
[ERROR] org.phoenicis.multithreading.ControlledThreadPoolExecutorService (l.64) - Path "/home/jonasz/.Phoenicis/containers//wineprefix//RimWorld//drive_c/windows/Fonts" does not exist
	at org.phoenicis.tools.files.FileUtilities.copy(FileUtilities.java:139)
	at <js> cp(Unnamed:56:1251-1284)
	at <js> go(Unnamed:40:1231-1295)
	at <js> install(Unnamed:57:1761-1781)
	at org.graalvm.sdk/org.graalvm.polyglot.Value.invokeMember(Value.java:457)
	at org.phoenicis.engines.VerbsManager.lambda$installVerb$0(VerbsManager.java:71)
	at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35)
	at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by host exception: java.lang.IllegalArgumentException: Path "/home/jonasz/.Phoenicis/containers//wineprefix//RimWorld//drive_c/windows/Fonts" does not exist

Exception in thread "pool-3-thread-5" Path "/home/jonasz/.Phoenicis/containers//wineprefix//RimWorld//drive_c/windows/Fonts" does not exist
	at org.phoenicis.tools.files.FileUtilities.copy(FileUtilities.java:139)
	at <js> cp(Unnamed:56:1251-1284)
	at <js> go(Unnamed:40:1231-1295)
	at <js> install(Unnamed:57:1761-1781)
	at org.graalvm.sdk/org.graalvm.polyglot.Value.invokeMember(Value.java:457)
	at org.phoenicis.engines.VerbsManager.lambda$installVerb$0(VerbsManager.java:71)
	at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35)
	at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by host exception: java.lang.IllegalArgumentException: Path "/home/jonasz/.Phoenicis/containers//wineprefix//RimWorld//drive_c/windows/Fonts" does not exist

ImperatorS79 · 2019-09-14T07:37:13Z

Yes, I have the same kind of error in other verbs when testing Adobe Photoshop script, that says system32 does not exist. But it was actually that it did not find the file to copy.

I do not know why we have this error.

madoar · 2019-09-14T07:39:49Z

The error only occurs when a CabExtract is followed by a cp instruction right?
If this is the case then maybe CabExtract returns before the filesystem has been updated/refreshed?

Can you try adding a java.lang.Thread.sleep(100); instruction between CabExtract and cp?

Zemogiter · 2019-09-14T07:47:17Z

@madoar done that, still getting the same error

madoar · 2019-09-14T07:57:03Z

I'm still confuses from which line in which script this error is thrown... The issue is that the source path/directory in a cp operation does not exist. So which script calls cp(fontDirectory, ...) in line 55? I am unable to even find a script that calls cp(fontDirectory, ...) at all...

plata · 2019-09-16T17:07:25Z

You can add some log output like

print("1");
// do something
print("2");
// do something more

to figure out where exactly the error is caused.

madoar · 2019-10-05T09:09:02Z

Are there any updates on this?

Zemogiter · 2019-10-30T14:29:49Z

Just copied the moded verbs and getting this error durring Sims 3 installation:

org.graalvm.polyglot.PolyglotException: TypeError: <this>.wine.overrideDLL is not a function
    at <js>.go (Unnamed:48)
    at <js>.:anonymous (Unnamed:20)
    at <js>.go (Unnamed:83)
    at com.oracle.truffle.polyglot.ObjectProxyHandler.invoke (HostInteropReflect.java:678)
    at com.sun.proxy.$Proxy64.go (Unknown Source)
    at org.phoenicis.javafx.components.application.skin.ApplicationInformationPanelSkin.lambda$installScript$7 (ApplicationInformationPanelSkin.java:237)
    at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval (PhoenicisInteractiveScriptSession.java:35)
    at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1 (BackgroundScriptInterpreter.java:45)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1128)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:628)
    at java.lang.Thread.run (Thread.java:834)

Runing the latest source code and script repo.

madoar · 2019-11-01T21:04:00Z

Yes the PR needs to be rebased. The changes to the plugins are not included.

Zemogiter · 2019-11-17T13:37:48Z

@ImperatorS79 please rebase

madoar

This PR needs to be rebased

Zemogiter · 2019-11-25T21:19:52Z

Too bad we can't use dependabot in non-dependabot PRs to rebase them.

Merge master

plata · 2019-11-26T18:12:33Z

https://github.com/cirrus-actions/rebase

Zemogiter · 2019-11-27T23:19:38Z

@ImperatorS79 please remove trailing spaces

plata · 2019-11-28T17:07:49Z

If you're interested in having this rebase action, please open an issue regarding it. Then we can discuss.

* Update script.js

ImperatorS79 added 23 commits August 28, 2017 15:19

Merge pull request #1 from PhoenicisOrg/master

06ad52f

Merge Phoenicis/Scripts:master into ImperatorS79/Scripts:master

Update script.js

86fd07c

Merge pull request #2 from PhoenicisOrg/master

a6f232b

updated Hearthstone (download application directly) (PhoenicisOrg#383)

Merge pull request #3 from PhoenicisOrg/master

a80aa84

Merge master

Merge pull request #4 from PhoenicisOrg/master

6da4a59

Merge recent commits

Merge pull request #8 from PhoenicisOrg/master

4a11f65

Merge master

Merge pull request #9 from PhoenicisOrg/master

b2d5724

Merge master

Merge pull request #10 from PhoenicisOrg/master

b7d1f0f

Merge master

Merge pull request #11 from PhoenicisOrg/master

533df6e

Merge master

Merge pull request #12 from PhoenicisOrg/master

186e4ed

Merge master

Merge pull request #13 from PhoenicisOrg/master

99cf1db

Merge master

Merge pull request #15 from PhoenicisOrg/master

87999b4

Merge master

Merge pull request #16 from PhoenicisOrg/master

610b258

Merge master

Merge pull request #17 from PhoenicisOrg/master

ad2ea01

Merge master

Merge pull request #18 from PhoenicisOrg/master

2e53a22

Merge master

Merge pull request #20 from PhoenicisOrg/master

10f93ca

Merge master

Merge pull request #21 from PhoenicisOrg/master

ade899d

Merge master

Merge pull request #23 from PhoenicisOrg/master

db6e1b9

Merge Master

Merge pull request #26 from PhoenicisOrg/master

da1a517

Merge master

Merge pull request #28 from PhoenicisOrg/master

72863e6

Merge master

Merge pull request #33 from PhoenicisOrg/master

f812551

Merge master

Update script.js

a3f62ce

Update script.js

d3ab4e2

ImperatorS79 added 2 commits September 7, 2019 11:42

Update script.js

276da5b

Update script.js

9d34f45

Zemogiter mentioned this pull request Sep 9, 2019

Phoenicis does not find directories that are obviously there #1107

Open

Merge branch 'master' into file-exists

d842fae

madoar approved these changes Sep 10, 2019

View reviewed changes

ImperatorS79 changed the title ~~File exists~~ Update tahoma and mfc42 verb: use fileExists Sep 11, 2019

madoar mentioned this pull request Sep 12, 2019

Split "fileExists" into "fileExists" and "directoryExists" #1124

Open

madoar requested changes Nov 25, 2019

View reviewed changes

madoar added the requires rebase This PR requires a git rebase label Nov 25, 2019

Merge pull request #36 from PhoenicisOrg/master

3d71e50

Merge master

ImperatorS79 added 2 commits November 28, 2019 14:26

Update script.js

b21f5af

Update script.js

2d1b2aa

madoar approved these changes Nov 28, 2019

View reviewed changes

madoar merged commit aab3342 into PhoenicisOrg:master Nov 28, 2019

petermetz pushed a commit to petermetz/scripts that referenced this pull request Jun 7, 2020

Update tahoma and mfc42 verb: use fileExists (PhoenicisOrg#1116)

334b5f9

* Update script.js

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update tahoma and mfc42 verb: use fileExists #1116

Update tahoma and mfc42 verb: use fileExists #1116

ImperatorS79 commented Sep 6, 2019 •

edited

Loading

ImperatorS79 commented Sep 6, 2019

madoar commented Sep 7, 2019

Zemogiter commented Sep 7, 2019

ImperatorS79 commented Sep 10, 2019

madoar Sep 10, 2019

plata Sep 11, 2019

madoar Sep 11, 2019

plata Sep 12, 2019

plata commented Sep 11, 2019

Zemogiter commented Sep 14, 2019

ImperatorS79 commented Sep 14, 2019 •

edited

Loading

madoar commented Sep 14, 2019

Zemogiter commented Sep 14, 2019

madoar commented Sep 14, 2019

plata commented Sep 16, 2019

madoar commented Oct 5, 2019

Zemogiter commented Oct 30, 2019 •

edited

Loading

madoar commented Nov 1, 2019

Zemogiter commented Nov 17, 2019 •

edited

Loading

madoar left a comment

Zemogiter commented Nov 25, 2019

plata commented Nov 26, 2019

Zemogiter commented Nov 27, 2019

plata commented Nov 28, 2019

Update tahoma and mfc42 verb: use fileExists #1116

Update tahoma and mfc42 verb: use fileExists #1116

Conversation

ImperatorS79 commented Sep 6, 2019 • edited Loading

Description

Ready for review

ImperatorS79 commented Sep 6, 2019

madoar commented Sep 7, 2019

Zemogiter commented Sep 7, 2019

ImperatorS79 commented Sep 10, 2019

madoar Sep 10, 2019

Choose a reason for hiding this comment

plata Sep 11, 2019

Choose a reason for hiding this comment

madoar Sep 11, 2019

Choose a reason for hiding this comment

plata Sep 12, 2019

Choose a reason for hiding this comment

plata commented Sep 11, 2019

Zemogiter commented Sep 14, 2019

ImperatorS79 commented Sep 14, 2019 • edited Loading

madoar commented Sep 14, 2019

Zemogiter commented Sep 14, 2019

madoar commented Sep 14, 2019

plata commented Sep 16, 2019

madoar commented Oct 5, 2019

Zemogiter commented Oct 30, 2019 • edited Loading

madoar commented Nov 1, 2019

Zemogiter commented Nov 17, 2019 • edited Loading

madoar left a comment

Choose a reason for hiding this comment

Zemogiter commented Nov 25, 2019

plata commented Nov 26, 2019

Zemogiter commented Nov 27, 2019

plata commented Nov 28, 2019

ImperatorS79 commented Sep 6, 2019 •

edited

Loading

ImperatorS79 commented Sep 14, 2019 •

edited

Loading

Zemogiter commented Oct 30, 2019 •

edited

Loading

Zemogiter commented Nov 17, 2019 •

edited

Loading