NetBSD compatibility: Increase daynaport minimum packet size to 128 bytes (#1334) #1335
Conversation
cpp/devices/scsi_daynaport.cpp
Outdated
| // 64 bytes it was decided to accept the broken checksum. If a driver should pop up that | ||
| // breaks because of this, the work-around has to be re-evaluated. | ||
| size = 64; | ||
| // that care for the checksum, the Daynaport driver for the Atari expects frames of 64 bytes |
There was a problem hiding this comment.
Sorry if I missed the whole discussion elsewhere, but you're saying that the Atari driver expects 64 bit frames but can handle 128 bit frames too because it's a multiple of 64?
(The resulting code comment reads contradictory to me)
Also, I assume @benjamink is helping you test this change with the Mac drivers?
There was a problem hiding this comment.
I tested this change successfully with the Atari driver, i.e. it can cope with 128 bytes. I guess anything > 64 bytes is fine, but 128 bytes definitely work.
Yes, @benjamink is doing the Mac tests.
The comment is indeed inconsistent. I just updated it, hope it is clearer now.
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.